content/browser/service_worker/service_worker_url_request_job.cc - Issue 2405483002: Make the request initiator Optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 2405483002: Make the request initiator Optional (Closed)

Patch Set: Rewrite using base::Optional Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_url_request_job.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc

index e979fdd1b24adfff05caa5684db8f9a1b6dcf4b0..90e9b63864e34c7a6d451d88800c287584c4ff73 100644

--- a/content/browser/service_worker/service_worker_url_request_job.cc

+++ b/content/browser/service_worker/service_worker_url_request_job.cc

@@ -776,7 +776,8 @@ bool ServiceWorkerURLRequestJob::IsFallbackToRendererNeeded() const {

fetch_type_ != ServiceWorkerFetchType::FOREIGN_FETCH &&

(request_mode_ == FETCH_REQUEST_MODE_CORS ||

request_mode_ == FETCH_REQUEST_MODE_CORS_WITH_FORCED_PREFLIGHT) &&

- !request()->initiator().IsSameOriginWith(

+ request()->initiator().has_value() &&

+ !request()->initiator()->IsSameOriginWith(

url::Origin(request()->url()));

}