content/browser/appcache/appcache_update_job.cc - Issue 2405483002: Make the request initiator Optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_update_job.cc

Issue 2405483002: Make the request initiator Optional (Closed)

Patch Set: Introduce NullableOrigin to use for request initiator Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_update_job.cc

diff --git a/content/browser/appcache/appcache_update_job.cc b/content/browser/appcache/appcache_update_job.cc

index 162dbe4616deb1c7de97e66c64bf194e6a69a978..162318ff3e0ccc802c78cca1d167f8bff3997f51 100644

--- a/content/browser/appcache/appcache_update_job.cc

+++ b/content/browser/appcache/appcache_update_job.cc

@@ -168,7 +168,7 @@ AppCacheUpdateJob::URLFetcher::~URLFetcher() {

void AppCacheUpdateJob::URLFetcher::Start() {

request_->set_first_party_for_cookies(job_->manifest_url_);

- request_->set_initiator(url::Origin(job_->manifest_url_));

+ request_->set_initiator(new url::NullableOrigin(job_->manifest_url_));

if (fetch_type_ == MANIFEST_FETCH && job_->doing_full_update_check_)

request_->SetLoadFlags(request_->load_flags() | net::LOAD_BYPASS_CACHE);

else if (existing_response_headers_.get())