Make the request initiator Optional

net/base/registry_controlled_domains/registry_controlled_domain.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NB: Modelled after Mozilla's code (originally written by Pamela Greene,
 // later modified by others), but almost entirely rewritten for Chrome.
 //   (netwerk/dns/src/nsEffectiveTLDService.cpp)
 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
@@ skipping 204 matching lines @@
                   gurl2.possibly_invalid_spec().data() + host2.begin,
                   host1.len);
 }
 
 bool SameDomainOrHost(const url::Origin& origin1,
                       const url::Origin& origin2,
                       PrivateRegistryFilter filter) {
   return SameDomainOrHost(origin1.GetURL(), origin2.GetURL(), filter);
 }
 
+bool SameDomainOrHost(const url::Origin& origin1,
+                      const base::Optional<url::Origin>& origin2,
+                      PrivateRegistryFilter filter) {
+  return SameDomainOrHost(
+      origin1, origin2.has_value() ? origin2.value() : url::Origin(), filter);

[Mike West, 2016/10/14 13:05:59]

Rather than passing in `url::Origin()`, could you just return `false` if
`!origin2.has_value()`?

[clamy, 2016/10/19 16:00:43]

Done.

+}
+
 size_t GetRegistryLength(
     const GURL& gurl,
     UnknownRegistryFilter unknown_filter,
     PrivateRegistryFilter private_filter) {
   base::StringPiece host = gurl.host_piece();
   if (host.empty())
     return std::string::npos;
   if (gurl.HostIsIPAddress())
     return 0;
   return GetRegistryLengthImpl(host, unknown_filter, private_filter);
@@ skipping 18 matching lines @@
 
 void SetFindDomainGraph(const unsigned char* domains, size_t length) {
   CHECK(domains);
   CHECK_NE(length, 0u);
   g_graph = domains;
   g_graph_length = length;
 }
 
 }  // namespace registry_controlled_domains
 }  // namespace net