Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: content/child/web_url_loader_impl.cc

Issue 2405483002: Make the request initiator Optional (Closed)
Patch Set: Introduce NullableOrigin to use for request initiator Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <openssl/ssl.h> 7 #include <openssl/ssl.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 // creating the GURLs. 522 // creating the GURLs.
523 523
524 // TODO(horo): Check credentials flag is unset when credentials mode is omit. 524 // TODO(horo): Check credentials flag is unset when credentials mode is omit.
525 // Check credentials flag is set when credentials mode is include. 525 // Check credentials flag is set when credentials mode is include.
526 526
527 std::unique_ptr<ResourceRequest> resource_request(new ResourceRequest); 527 std::unique_ptr<ResourceRequest> resource_request(new ResourceRequest);
528 528
529 resource_request->method = method; 529 resource_request->method = method;
530 resource_request->url = url; 530 resource_request->url = url;
531 resource_request->first_party_for_cookies = request.firstPartyForCookies(); 531 resource_request->first_party_for_cookies = request.firstPartyForCookies();
532 resource_request->request_initiator = request.requestorOrigin(); 532 if (!request.requestorOrigin().isNull()) {
533 resource_request->request_initiator =
534 new url::NullableOrigin(request.requestorOrigin());
nasko 2016/10/10 22:28:11 Isn't the goal of a nullable origin to have it alw
535 }
533 resource_request->referrer = referrer_url; 536 resource_request->referrer = referrer_url;
534 537
535 referrer_policy_ = request.referrerPolicy(); 538 referrer_policy_ = request.referrerPolicy();
536 resource_request->referrer_policy = referrer_policy_; 539 resource_request->referrer_policy = referrer_policy_;
537 540
538 resource_request->headers = GetWebURLRequestHeaders(request); 541 resource_request->headers = GetWebURLRequestHeaders(request);
539 resource_request->load_flags = GetLoadFlagsForWebURLRequest(request); 542 resource_request->load_flags = GetLoadFlagsForWebURLRequest(request);
540 // origin_pid only needs to be non-zero if the request originates outside 543 // origin_pid only needs to be non-zero if the request originates outside
541 // the render process, so we can use requestorProcessID even for requests 544 // the render process, so we can use requestorProcessID even for requests
542 // from in-process plugins. 545 // from in-process plugins.
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
1269 response->clearHTTPHeaderField(webStringName); 1272 response->clearHTTPHeaderField(webStringName);
1270 while (response_headers->EnumerateHeader(&iterator, name, &value)) { 1273 while (response_headers->EnumerateHeader(&iterator, name, &value)) {
1271 response->addHTTPHeaderField(webStringName, 1274 response->addHTTPHeaderField(webStringName,
1272 WebString::fromLatin1(value)); 1275 WebString::fromLatin1(value));
1273 } 1276 }
1274 } 1277 }
1275 return true; 1278 return true;
1276 } 1279 }
1277 1280
1278 } // namespace content 1281 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698