Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: content/child/web_url_loader_impl.cc

Issue 2405483002: Make the request initiator Optional (Closed)
Patch Set: Addressed comments + rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/web_url_loader_impl.h" 5 #include "content/child/web_url_loader_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <memory> 10 #include <memory>
11 #include <string> 11 #include <string>
12 #include <utility> 12 #include <utility>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/bind.h" 15 #include "base/bind.h"
16 #include "base/files/file_path.h" 16 #include "base/files/file_path.h"
17 #include "base/logging.h" 17 #include "base/logging.h"
18 #include "base/memory/ptr_util.h" 18 #include "base/memory/ptr_util.h"
19 #include "base/optional.h"
19 #include "base/single_thread_task_runner.h" 20 #include "base/single_thread_task_runner.h"
20 #include "base/strings/string_number_conversions.h" 21 #include "base/strings/string_number_conversions.h"
21 #include "base/strings/string_util.h" 22 #include "base/strings/string_util.h"
22 #include "base/time/time.h" 23 #include "base/time/time.h"
23 #include "build/build_config.h" 24 #include "build/build_config.h"
24 #include "components/mime_util/mime_util.h" 25 #include "components/mime_util/mime_util.h"
25 #include "content/child/child_thread_impl.h" 26 #include "content/child/child_thread_impl.h"
26 #include "content/child/ftp_directory_listing_response_delegate.h" 27 #include "content/child/ftp_directory_listing_response_delegate.h"
27 #include "content/child/request_extra_data.h" 28 #include "content/child/request_extra_data.h"
28 #include "content/child/resource_dispatcher.h" 29 #include "content/child/resource_dispatcher.h"
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 // creating the GURLs. 542 // creating the GURLs.
542 543
543 // TODO(horo): Check credentials flag is unset when credentials mode is omit. 544 // TODO(horo): Check credentials flag is unset when credentials mode is omit.
544 // Check credentials flag is set when credentials mode is include. 545 // Check credentials flag is set when credentials mode is include.
545 546
546 std::unique_ptr<ResourceRequest> resource_request(new ResourceRequest); 547 std::unique_ptr<ResourceRequest> resource_request(new ResourceRequest);
547 548
548 resource_request->method = method; 549 resource_request->method = method;
549 resource_request->url = url; 550 resource_request->url = url;
550 resource_request->first_party_for_cookies = request.firstPartyForCookies(); 551 resource_request->first_party_for_cookies = request.firstPartyForCookies();
551 resource_request->request_initiator = request.requestorOrigin(); 552 resource_request->request_initiator =
553 request.requestorOrigin().isNull()
554 ? base::Optional<url::Origin>()
555 : base::Optional<url::Origin>(request.requestorOrigin());
552 resource_request->referrer = referrer_url; 556 resource_request->referrer = referrer_url;
553 557
554 resource_request->referrer_policy = request.referrerPolicy(); 558 resource_request->referrer_policy = request.referrerPolicy();
555 559
556 resource_request->headers = GetWebURLRequestHeaders(request); 560 resource_request->headers = GetWebURLRequestHeaders(request);
557 resource_request->load_flags = GetLoadFlagsForWebURLRequest(request); 561 resource_request->load_flags = GetLoadFlagsForWebURLRequest(request);
558 // origin_pid only needs to be non-zero if the request originates outside 562 // origin_pid only needs to be non-zero if the request originates outside
559 // the render process, so we can use requestorProcessID even for requests 563 // the render process, so we can use requestorProcessID even for requests
560 // from in-process plugins. 564 // from in-process plugins.
561 resource_request->origin_pid = request.requestorProcessID(); 565 resource_request->origin_pid = request.requestorProcessID();
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1239 int intra_priority_value) { 1243 int intra_priority_value) {
1240 context_->DidChangePriority(new_priority, intra_priority_value); 1244 context_->DidChangePriority(new_priority, intra_priority_value);
1241 } 1245 }
1242 1246
1243 void WebURLLoaderImpl::setLoadingTaskRunner( 1247 void WebURLLoaderImpl::setLoadingTaskRunner(
1244 base::SingleThreadTaskRunner* loading_task_runner) { 1248 base::SingleThreadTaskRunner* loading_task_runner) {
1245 context_->SetTaskRunner(loading_task_runner); 1249 context_->SetTaskRunner(loading_task_runner);
1246 } 1250 }
1247 1251
1248 } // namespace content 1252 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | content/common/net/url_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698