Make the request initiator Optional

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/debug/leak_tracker.h"
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/optional.h"
 #include "base/strings/string16.h"
 #include "base/supports_user_data.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/time/time.h"
 #include "net/base/auth.h"
 #include "net/base/completion_callback.h"
 #include "net/base/load_states.h"
 #include "net/base/load_timing_info.h"
 #include "net/base/net_error_details.h"
 #include "net/base/net_export.h"
@@ skipping 269 matching lines @@
   //    each of those requests will be `https://example.com/`.
   //
   // 2. The request's initiator is the origin of the frame or worker which made
   //    the request, even for top-level navigations. That is, if
   //    `https://example.com/`'s form submission is made in the top-level frame,
   //    the first party for cookies would be the target URL's origin. The
   //    initiator remains `https://example.com/`.
   //
   // This value is used to perform the cross-origin check specified in Section
   // 4.3 of https://tools.ietf.org/html/draft-west-first-party-cookies.
-  const url::Origin& initiator() const { return initiator_; }
+  const base::Optional<url::Origin>& initiator() const { return initiator_; }
   // This method may only be called before Start().

[mmenke, 2016/11/03 17:58:58]

Is it worth mentioning the difference between a unique and invalid initiator?

[clamy, 2016/11/04 16:03:50]

Done.

-  void set_initiator(const url::Origin& initiator);
+  void set_initiator(const base::Optional<url::Origin>& initiator);
 
   // The request method, as an uppercase string.  "GET" is the default value.
   // The request method may only be changed before Start() is called and
   // should only be assigned an uppercase value.
   const std::string& method() const { return method_; }
   void set_method(const std::string& method);
 
   // The referrer URL for the request.  This header may actually be suppressed
   // from the underlying network request for security reasons (e.g., a HTTPS
   // URL will not be sent as the referrer for a HTTP request).  The referrer
@@ skipping 435 matching lines @@
   NetworkDelegate* network_delegate_;
 
   // Tracks the time spent in various load states throughout this request.
   NetLogWithSource net_log_;
 
   std::unique_ptr<URLRequestJob> job_;
   std::unique_ptr<UploadDataStream> upload_data_stream_;
 
   std::vector<GURL> url_chain_;
   GURL first_party_for_cookies_;
-  url::Origin initiator_;
+  base::Optional<url::Origin> initiator_;
   GURL delegate_redirect_url_;
   std::string method_;  // "GET", "POST", etc. Should be all uppercase.
   std::string referrer_;
   ReferrerPolicy referrer_policy_;
   std::string token_binding_referrer_;
   FirstPartyURLPolicy first_party_url_policy_;
   HttpRequestHeaders extra_request_headers_;
   int load_flags_;  // Flags indicating the request type for the load;
                     // expected values are LOAD_* enums above.
 
@@ skipping 81 matching lines @@
 
   // The raw header size of the response.
   int raw_header_size_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_