Fix Integer-overflow in base::Time::FromExploded.

base/time/time.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Time represents an absolute point in coordinated universal time (UTC),
 // internally represented as microseconds (s/1,000,000) since the Windows epoch
 // (1601-01-01 00:00:00 UTC). System-dependent clock interface routines are
 // defined in time_PLATFORM.cc. Note that values for Time may skew and jump
 // around as the operating system makes adjustments to synchronize (e.g., with
 // NTP servers). Thus, client code that uses the Time class must account for
@@ skipping 527 matching lines @@
     return time;
   }
   static Time FromLocalExploded(const Exploded& exploded) {
     base::Time time;
     ignore_result(FromLocalExploded(exploded, &time));
     return time;
   }
 
   // Converts an exploded structure representing either the local time or UTC
   // into a Time class. Returns false on a failure when, for example, a day of
-  // month is set to 31 on a 28-30 day month.
+  // month is set to 31 on a 28-30 day month. Returns maximum possible

[miu, 2016/10/18 19:55:13]

IMO, if there is any overflow, this function should return false instead of just
returning "max possible time" because the conversion is not possible.

Or, can you point at specific code that requires this behavior?

[maksims (do not use this acc), 2016/10/19 16:41:04]

That's a typo. At first I thought it would be like this. It returns Time(0), of
course.

+  // platform dependent time on overflow.
   static bool FromUTCExploded(const Exploded& exploded,
                               Time* time) WARN_UNUSED_RESULT {
     return FromExploded(false, exploded, time);
   }
   static bool FromLocalExploded(const Exploded& exploded,
                                 Time* time) WARN_UNUSED_RESULT {
     return FromExploded(true, exploded, time);
   }
 
   // Converts a string representation of time to a Time object.
@@ skipping 283 matching lines @@
   static void WaitUntilInitializedWin();
 #endif
 };
 
 // For logging use only.
 BASE_EXPORT std::ostream& operator<<(std::ostream& os, ThreadTicks time_ticks);
 
 }  // namespace base
 
 #endif  // BASE_TIME_TIME_H_