Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2405433002: Ntp: rename local variables to be less verbose. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ntp: rename local variables to be less verbose. Committed: https://crrev.com/4354c8cdc4ce55850dec163f98beca0383c37bc2 Cr-Commit-Position: refs/heads/master@{#423837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 5 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 2 months ago (2016-10-07 11:27:28 UTC) #4
PEConn
LGTM as a step on your quest to show up on git blame for every ...
4 years, 2 months ago (2016-10-07 11:36:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405433002/1
4 years, 2 months ago (2016-10-07 12:21:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 12:27:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:28:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4354c8cdc4ce55850dec163f98beca0383c37bc2
Cr-Commit-Position: refs/heads/master@{#423837}

Powered by Google App Engine
This is Rietveld 408576698