[Video Capture Service] Move Mojo structs and enums to media/capture/mojo

media/mojo/interfaces/media_types.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module media.mojom;
 
 import "ui/gfx/geometry/mojo/geometry.mojom";
 import "mojo/common/common_custom_types.mojom";
 
 // See media/base/buffering_state.h for descriptions.
@@ skipping 10 matching lines @@
 
 // See media/base/channel_layout.h for descriptions.
 [Native]
 enum ChannelLayout;
 
 // See media/base/sample_format.h for descriptions.
 [Native]
 enum SampleFormat;
 
 // See media/base/video_types.h for descriptions.
-[Native]
-enum VideoPixelFormat;
+enum VideoPixelFormat {

[xhwang, 2016/10/27 04:57:09]

OOC, why are you making this change?

[chfremer, 2016/10/27 17:15:44]

My goal was to be able to use EnumTraits<> for typemapping in order to avoid the
static_cast<> that was used in the StructTraits<VideoCaptureFormat> here [1]. 

With the [Native] enum, I was not able to make things work. It seems to do this
conversion, Mojo requires us to provide a
IPC::ParamTraits<media::VideoPixelFormat>::Read(). We did not seem to have this,
and since IPC::ParamTraits is considered "legacy", I decided it would be better
to replace the native enum with a Mojo enum instead of implementing the missing
IPC::ParamTraits<>.

[1]
https://codereview.chromium.org/2405423002/diff/60001/media/mojo/interfaces/m...

[xhwang, 2016/10/27 17:22:37]

IPC::ParamTraits is the current recommended/allowed way for enums, see:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/y-c0l8nKcn0

The manually typed EnumTraits is error prone and we don't have test covering it.
(You can add a test, but it'll be more boilerplate code).

The existing [Native] VideoPixelFormat should work for you. I think you are
missing some dependencies here. Could you please try again and post the exact
error here?

[chfremer, 2016/10/27 20:32:18]

I figured out the issue I had. I forgot to add #include
"media/base/ipc/media_param_traits_macros.h" to get the needed ParamTraits<>
implementation.

Reverted back to [Native]. Thanks for pointing this out.

+  UNKNOWN,
+  I420,
+  YV12,
+  YV16,
+  YV12A,
+  YV24,
+  NV12,
+  NV21,
+  UYVY,
+  YUY2,
+  ARGB,
+  XRGB,
+  RGB24,
+  RGB32,
+  MJPEG,
+  MT21,
+  YUV420P9,
+  YUV420P10,
+  YUV422P9,
+  YUV422P10,
+  YUV444P9,
+  YUV444P10,
+  YUV420P12,
+  YUV422P12,
+  YUV444P12,
+  Y8,
+  Y16,
+};
 
 // See media/base/video_types.h for descriptions.
 [Native]
 enum ColorSpace;
 
 // See media/base/video_codecs.h for descriptions.
 [Native]
 enum VideoCodec;
 
 // See media/base/video_codecs.h for descriptions.
@@ skipping 144 matching lines @@
 };
 
 struct PipelineStatistics {
   uint64 audio_bytes_decoded;
   uint64 video_bytes_decoded;
   uint32 video_frames_decoded;
   uint32 video_frames_dropped;
   int64 audio_memory_usage;
   int64 video_memory_usage;
 };