Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2405413002:
Reland of [Chromoting] Reenable 64-bit build checks for Windows (Closed)
DescriptionReland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ )
Reason for revert:
Resubmit original change https://codereview.chromium.org/2403923003/.
Original issue's description:
> Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ )
>
> Reason for revert:
> Speculative revert for possibly causing a failure of official build. See crbug.com/654818
>
> Original issue's description:
> > [Chromoting] Reenable 64-bit build checks for Windows
> >
> > After discussing with team members, we prefer to keep generating 64 bit host archive.
> >
> > BUG=623077
> >
> > TBR=mmoss@chromium.org
> >
> > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59
> > Cr-Commit-Position: refs/heads/master@{#424314}
>
> TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=623077
>
> Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1
> Cr-Commit-Position: refs/heads/master@{#424503}
TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623077
Committed: https://crrev.com/cecf7722096a54885fa1c620f0ee34b54b56c741
Cr-Commit-Position: refs/heads/master@{#426044}
Patch Set 1 #Patch Set 2 : Add remoting host into the dependencies of official build #Patch Set 3 : Integrate 2410163003 #Messages
Total messages: 41 (21 generated)
The CQ bit was checked by zijiehe@chromium.org
Created Reland of [Chromoting] Reenable 64-bit build checks for Windows
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was unchecked by zijiehe@chromium.org
On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Why commit is on by default?
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/11 23:20:16, Hzj_jie wrote: > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started by full committers or once the patch has > > received an L-G-T-M from a full committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > See http://www.chromium.org/getting-involved/become-a-committer > > Note that this has nothing to do with OWNERS files. > > Why commit is on by default? Michael, is there a way to test the change before submitting it?
On 2016/10/11 23:32:52, Hzj_jie wrote: > On 2016/10/11 23:20:16, Hzj_jie wrote: > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > No L-G-T-M from a valid reviewer yet. > > > CQ run can only be started by full committers or once the patch has > > > received an L-G-T-M from a full committer. > > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > See http://www.chromium.org/getting-involved/become-a-committer > > > Note that this has nothing to do with OWNERS files. > > > > Why commit is on by default? > > Michael, is there a way to test the change before submitting it? Just remove NO*=true from the description.
On 2016/10/11 23:49:44, alph wrote: > On 2016/10/11 23:32:52, Hzj_jie wrote: > > On 2016/10/11 23:20:16, Hzj_jie wrote: > > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > > No L-G-T-M from a valid reviewer yet. > > > > CQ run can only be started by full committers or once the patch has > > > > received an L-G-T-M from a full committer. > > > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > > > _not_ a full super star committer. > > > > See http://www.chromium.org/getting-involved/become-a-committer > > > > Note that this has nothing to do with OWNERS files. > > > > > > Why commit is on by default? > > > > Michael, is there a way to test the change before submitting it? > > Just remove NO*=true from the description. I have not found the official build trybot.
On 2016/10/11 23:50:53, Hzj_jie wrote: > On 2016/10/11 23:49:44, alph wrote: > > On 2016/10/11 23:32:52, Hzj_jie wrote: > > > On 2016/10/11 23:20:16, Hzj_jie wrote: > > > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > > > No L-G-T-M from a valid reviewer yet. > > > > > CQ run can only be started by full committers or once the patch has > > > > > received an L-G-T-M from a full committer. > > > > > Even if an L-G-T-M may have been provided, it was from a non-committer, > > > > > _not_ a full super star committer. > > > > > See http://www.chromium.org/getting-involved/become-a-committer > > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > Why commit is on by default? > > > > > > Michael, is there a way to test the change before submitting it? > > > > Just remove NO*=true from the description. > > I have not found the official build trybot. There isn't one. The safest thing to do would be to submit the GN change and make sure the files you expect to be built are built in the next release, then submit the FILES.cfg change to use those files.
On 2016/10/12 02:07:42, Michael Moss wrote: > On 2016/10/11 23:50:53, Hzj_jie wrote: > > On 2016/10/11 23:49:44, alph wrote: > > > On 2016/10/11 23:32:52, Hzj_jie wrote: > > > > On 2016/10/11 23:20:16, Hzj_jie wrote: > > > > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > > > > No L-G-T-M from a valid reviewer yet. > > > > > > CQ run can only be started by full committers or once the patch has > > > > > > received an L-G-T-M from a full committer. > > > > > > Even if an L-G-T-M may have been provided, it was from a > non-committer, > > > > > > _not_ a full super star committer. > > > > > > See http://www.chromium.org/getting-involved/become-a-committer > > > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > > > Why commit is on by default? > > > > > > > > Michael, is there a way to test the change before submitting it? > > > > > > Just remove NO*=true from the description. > > > > I have not found the official build trybot. > > There isn't one. The safest thing to do would be to submit the GN change and > make sure the files you expect to be built are built in the next release, then > submit the FILES.cfg change to use those files. Thanks, I started another change https://codereview.chromium.org/2410163003/.
Description was changed from ========== Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ ) Reason for revert: Resubmit original change https://codereview.chromium.org/2403923003/. Original issue's description: > Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) > > Reason for revert: > Speculative revert for possibly causing a failure of official build. See crbug.com/654818 > > Original issue's description: > > [Chromoting] Reenable 64-bit build checks for Windows > > > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > > > BUG=623077 > > > > TBR=mmoss@chromium.org > > > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > > Cr-Commit-Position: refs/heads/master@{#424314} > > TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=623077 > > Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 > Cr-Commit-Position: refs/heads/master@{#424503} TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 ========== to ========== Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ ) Reason for revert: Resubmit original change https://codereview.chromium.org/2403923003/. Original issue's description: > Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) > > Reason for revert: > Speculative revert for possibly causing a failure of official build. See crbug.com/654818 > > Original issue's description: > > [Chromoting] Reenable 64-bit build checks for Windows > > > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > > > BUG=623077 > > > > TBR=mmoss@chromium.org > > > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > > Cr-Commit-Position: refs/heads/master@{#424314} > > TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=623077 > > Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 > Cr-Commit-Position: refs/heads/master@{#424503} TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 ==========
alph@chromium.org changed reviewers: - alph@chromium.org
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:60001) has been deleted
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/12 02:17:32, Hzj_jie wrote: > On 2016/10/12 02:07:42, Michael Moss wrote: > > On 2016/10/11 23:50:53, Hzj_jie wrote: > > > On 2016/10/11 23:49:44, alph wrote: > > > > On 2016/10/11 23:32:52, Hzj_jie wrote: > > > > > On 2016/10/11 23:20:16, Hzj_jie wrote: > > > > > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > > > > > No L-G-T-M from a valid reviewer yet. > > > > > > > CQ run can only be started by full committers or once the patch has > > > > > > > received an L-G-T-M from a full committer. > > > > > > > Even if an L-G-T-M may have been provided, it was from a > > non-committer, > > > > > > > _not_ a full super star committer. > > > > > > > See http://www.chromium.org/getting-involved/become-a-committer > > > > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > > > > > Why commit is on by default? > > > > > > > > > > Michael, is there a way to test the change before submitting it? > > > > > > > > Just remove NO*=true from the description. > > > > > > I have not found the official build trybot. > > > > There isn't one. The safest thing to do would be to submit the GN change and > > make sure the files you expect to be built are built in the next release, then > > submit the FILES.cfg change to use those files. > > Thanks, I started another change https://codereview.chromium.org/2410163003/. Michael, The change 2410163003 has been submitted, but I still cannot find the target in build log (https://uberchromegw.corp.google.com/i/official.desktop/builders/win64/builds...). I think a potential issue is is_chrome_branded != true, and I do not find is_chrome_branded has been set in compile.py and build log. Is it expected? If so, I will remove the if (is_chrome_branded) condition in BUILD.gn. Thank you.
That's an M54 build. Unless you merged to the beta/stable branches, it won't have your GN changes. You need to look at an M56 (canary) build. On Mon, Oct 17, 2016 at 12:45 PM, <zijiehe@chromium.org> wrote: > On 2016/10/12 02:17:32, Hzj_jie wrote: > > On 2016/10/12 02:07:42, Michael Moss wrote: > > > On 2016/10/11 23:50:53, Hzj_jie wrote: > > > > On 2016/10/11 23:49:44, alph wrote: > > > > > On 2016/10/11 23:32:52, Hzj_jie wrote: > > > > > > On 2016/10/11 23:20:16, Hzj_jie wrote: > > > > > > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > > > > > > No L-G-T-M from a valid reviewer yet. > > > > > > > > CQ run can only be started by full committers or once the > patch > has > > > > > > > > received an L-G-T-M from a full committer. > > > > > > > > Even if an L-G-T-M may have been provided, it was from a > > > non-committer, > > > > > > > > _not_ a full super star committer. > > > > > > > > See http://www.chromium.org/getting-involved/become-a- > committer > > > > > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > > > > > > > Why commit is on by default? > > > > > > > > > > > > Michael, is there a way to test the change before submitting it? > > > > > > > > > > Just remove NO*=true from the description. > > > > > > > > I have not found the official build trybot. > > > > > > There isn't one. The safest thing to do would be to submit the GN > change and > > > make sure the files you expect to be built are built in the next > release, > then > > > submit the FILES.cfg change to use those files. > > > > Thanks, I started another change https://codereview.chromium. > org/2410163003/. > > Michael, > The change 2410163003 has been submitted, but I still cannot find the > target in > build log > (https://uberchromegw.corp.google.com/i/official.desktop/ > builders/win64/builds/1161/steps/compile/logs/stdio). > I think a potential issue is is_chrome_branded != true, and I do not find > is_chrome_branded has been set in compile.py and build log. Is it > expected? If > so, I will remove the if (is_chrome_branded) condition in BUILD.gn. > > Thank you. > > https://codereview.chromium.org/2405413002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/10/17 19:59:56, Michael Moss wrote: > That's an M54 build. Unless you merged to the beta/stable branches, it > won't have your GN changes. You need to look at an M56 (canary) build. > > On Mon, Oct 17, 2016 at 12:45 PM, <mailto:zijiehe@chromium.org> wrote: > > > On 2016/10/12 02:17:32, Hzj_jie wrote: > > > On 2016/10/12 02:07:42, Michael Moss wrote: > > > > On 2016/10/11 23:50:53, Hzj_jie wrote: > > > > > On 2016/10/11 23:49:44, alph wrote: > > > > > > On 2016/10/11 23:32:52, Hzj_jie wrote: > > > > > > > On 2016/10/11 23:20:16, Hzj_jie wrote: > > > > > > > > On 2016/10/11 23:19:09, commit-bot: I haz the power wrote: > > > > > > > > > No L-G-T-M from a valid reviewer yet. > > > > > > > > > CQ run can only be started by full committers or once the > > patch > > has > > > > > > > > > received an L-G-T-M from a full committer. > > > > > > > > > Even if an L-G-T-M may have been provided, it was from a > > > > non-committer, > > > > > > > > > _not_ a full super star committer. > > > > > > > > > See http://www.chromium.org/getting-involved/become-a- > > committer > > > > > > > > > Note that this has nothing to do with OWNERS files. > > > > > > > > > > > > > > > > Why commit is on by default? > > > > > > > > > > > > > > Michael, is there a way to test the change before submitting it? > > > > > > > > > > > > Just remove NO*=true from the description. > > > > > > > > > > I have not found the official build trybot. > > > > > > > > There isn't one. The safest thing to do would be to submit the GN > > change and > > > > make sure the files you expect to be built are built in the next > > release, > > then > > > > submit the FILES.cfg change to use those files. > > > > > > Thanks, I started another change https://codereview.chromium. > > org/2410163003/. > > > > Michael, > > The change 2410163003 has been submitted, but I still cannot find the > > target in > > build log > > (https://uberchromegw.corp.google.com/i/official.desktop/ > > builders/win64/builds/1161/steps/compile/logs/stdio). > > I think a potential issue is is_chrome_branded != true, and I do not find > > is_chrome_branded has been set in compile.py and build log. Is it > > expected? If > > so, I will remove the if (is_chrome_branded) condition in BUILD.gn. > > > > Thank you. > > > > https://codereview.chromium.org/2405413002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. Is this (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang6...) the right link? Though it's a debug build.
> Is this > (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang6...) > the right link? Though it's a debug build. That's a public (dev) build, not an official build. There should be a canary build from last night, let me find it.
On 2016/10/18 20:39:22, Michael Moss wrote: > > Is this > > > (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang6...) > > the right link? Though it's a debug build. > > That's a public (dev) build, not an official build. There should be a canary > build from last night, let me find it. https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-pgo/bu...
On 2016/10/18 20:44:26, Michael Moss wrote: > On 2016/10/18 20:39:22, Michael Moss wrote: > > > Is this > > > > > > (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWinClang6...) > > > the right link? Though it's a debug build. > > > > That's a public (dev) build, not an official build. There should be a canary > > build from last night, let me find it. > > https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-pgo/bu... Thank you Michael. So PGO really means canary, right? And I have found all the required files are correctly built. This change is ready to bbe submitted.
> Thank you Michael. So PGO really means canary, right? No, PGO is used for all Windows builds now. The only thing that indicates canary is the version being built (i.e. 56.x.x.x builds). > And I have found all the required files are correctly built. This change is > ready to bbe submitted LGTM
On 2016/10/18 21:01:20, Michael Moss wrote: > > Thank you Michael. So PGO really means canary, right? > > No, PGO is used for all Windows builds now. The only thing that indicates canary > is the version being built (i.e. 56.x.x.x builds). > > > And I have found all the required files are correctly built. This change is > > ready to bbe submitted > > LGTM I see, thank you for the help.
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ ) Reason for revert: Resubmit original change https://codereview.chromium.org/2403923003/. Original issue's description: > Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) > > Reason for revert: > Speculative revert for possibly causing a failure of official build. See crbug.com/654818 > > Original issue's description: > > [Chromoting] Reenable 64-bit build checks for Windows > > > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > > > BUG=623077 > > > > TBR=mmoss@chromium.org > > > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > > Cr-Commit-Position: refs/heads/master@{#424314} > > TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=623077 > > Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 > Cr-Commit-Position: refs/heads/master@{#424503} TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 ========== to ========== Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ ) Reason for revert: Resubmit original change https://codereview.chromium.org/2403923003/. Original issue's description: > Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) > > Reason for revert: > Speculative revert for possibly causing a failure of official build. See crbug.com/654818 > > Original issue's description: > > [Chromoting] Reenable 64-bit build checks for Windows > > > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > > > BUG=623077 > > > > TBR=mmoss@chromium.org > > > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > > Cr-Commit-Position: refs/heads/master@{#424314} > > TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=623077 > > Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 > Cr-Commit-Position: refs/heads/master@{#424503} TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ ) Reason for revert: Resubmit original change https://codereview.chromium.org/2403923003/. Original issue's description: > Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) > > Reason for revert: > Speculative revert for possibly causing a failure of official build. See crbug.com/654818 > > Original issue's description: > > [Chromoting] Reenable 64-bit build checks for Windows > > > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > > > BUG=623077 > > > > TBR=mmoss@chromium.org > > > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > > Cr-Commit-Position: refs/heads/master@{#424314} > > TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=623077 > > Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 > Cr-Commit-Position: refs/heads/master@{#424503} TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 ========== to ========== Reland of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2405253003/ ) Reason for revert: Resubmit original change https://codereview.chromium.org/2403923003/. Original issue's description: > Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) > > Reason for revert: > Speculative revert for possibly causing a failure of official build. See crbug.com/654818 > > Original issue's description: > > [Chromoting] Reenable 64-bit build checks for Windows > > > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > > > BUG=623077 > > > > TBR=mmoss@chromium.org > > > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > > Cr-Commit-Position: refs/heads/master@{#424314} > > TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=623077 > > Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 > Cr-Commit-Position: refs/heads/master@{#424503} TBR=joedow@chromium.org,mmoss@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 Committed: https://crrev.com/cecf7722096a54885fa1c620f0ee34b54b56c741 Cr-Commit-Position: refs/heads/master@{#426044} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/cecf7722096a54885fa1c620f0ee34b54b56c741 Cr-Commit-Position: refs/heads/master@{#426044} |
