Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2405403002: Remove net::EnableSSLServerSockets. (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove net::EnableSSLServerSockets. With NSS gone, this function is now a no-op. BUG=604728 Committed: https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253 Cr-Commit-Position: refs/heads/master@{#425366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/socket/ssl_server_socket.h View 1 chunk +0 lines, -10 lines 0 comments Download
M net/socket/ssl_server_socket_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/test/run_all_unittests.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M remoting/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/base/run_all_unittests.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
davidben
svaldez for net/ sergeyu for remoting/ derat for chrome/browser/chromeos/chrome_browser_main_chromeos.cc
4 years, 2 months ago (2016-10-11 23:09:50 UTC) #6
Daniel Erat
lgtm for c/b/chromeos. thanks for cleaning this up!
4 years, 2 months ago (2016-10-11 23:19:13 UTC) #7
svaldez
Can you toss the NSS removal bug number on this CL? lgtm
4 years, 2 months ago (2016-10-12 14:44:54 UTC) #8
davidben
On 2016/10/12 14:44:54, svaldez wrote: > Can you toss the NSS removal bug number on ...
4 years, 2 months ago (2016-10-12 14:59:24 UTC) #10
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-14 16:11:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405403002/1
4 years, 2 months ago (2016-10-14 16:16:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 17:11:39 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 17:13:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21fcb69c3825bb655f87f69ea6a8408616717253
Cr-Commit-Position: refs/heads/master@{#425366}

Powered by Google App Engine
This is Rietveld 408576698