Use a single file for app snapshots.

runtime/bin/file.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_FILE_H_
 #define BIN_FILE_H_
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ skipping 70 matching lines @@
     kLockUnlock = 0,
     kLockShared = 1,
     kLockExclusive = 2,
     kLockBlockingShared = 3,
     kLockBlockingExclusive = 4,
     kLockMax = 4
   };
 
   intptr_t GetFD();
 
-  void* MapExecutable(intptr_t* num_bytes);
+  void* MapReadOnly(int64_t position, int64_t length);
+  void* MapReadExecute(int64_t position, int64_t length);

[siva, 2016/10/12 20:37:33]

Instead of having two entry points would it make sense to have just one

enum MapType {
  kReadOnly = 0,
  kReadExecute = 1,
  kReadWrite = 2,
};
void* Map(int64_t position, int64_t length, MapType type);

[rmacnak, 2016/10/13 01:08:16]

Done.

 
   // Read/Write attempt to transfer num_bytes to/from buffer. It returns
   // the number of bytes read/written.
   int64_t Read(void* buffer, int64_t num_bytes);
   int64_t Write(const void* buffer, int64_t num_bytes);
 
   // ReadFully and WriteFully do attempt to transfer num_bytes to/from
   // the buffer. In the event of short accesses they will loop internally until
   // the whole buffer has been transferred or an error occurs. If an error
   // occurred the result will be set to false.
@@ skipping 132 matching lines @@
   Dart_WeakPersistentHandle weak_handle_;
 
   friend class ReferenceCounted<File>;
   DISALLOW_COPY_AND_ASSIGN(File);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // BIN_FILE_H_