Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2405383002: Patch imports and function type aliases. Report more errors. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -11 lines) Patch
M pkg/analyzer/lib/src/dart/sdk/patch.dart View 4 chunks +57 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/patch_test.dart View 4 chunks +90 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 2 months ago (2016-10-11 22:05:21 UTC) #1
Paul Berry
lgtm
4 years, 2 months ago (2016-10-11 22:09:35 UTC) #2
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-11 22:11:03 UTC) #3
scheglov
4 years, 2 months ago (2016-10-12 00:09:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2150f5d1d17827535c31bbe6ffd0cefb23e267c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698