Add tests for native app redirects in herb.

Add tests for native app redirects in herb.

BUG=653254
Committed: https://crrev.com/680a1d0d69eb542dfbe8131d5bab49db6ce26271
Cr-Commit-Position: refs/heads/master@{#424619}

[Ted C, 2016-10-11 19:40:26]

tedchoc@chromium.org changed reviewers:
+ mariakhomenko@chromium.org, yusufo@chromium.org

[Ted C, 2016-10-11 19:40:26]

PTAL

[Maria, 2016-10-11 21:48:16]

https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
(right):

https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java:76:
CriteriaHelper.pollUiThread(new Criteria() {
why do we need to poll UI thread for this? I thought the idea of having
createdCct set as an atomic reference was to have the state reflected across
threads?

https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java:155:
public boolean isSatisfied() {
Hmm, do we restart everything on per-testcase or per test basis? I wonder if you
switching to a different app would cause the other testcase not to run properly
if it ran after this one.

[Maria, 2016-10-11 22:16:54]

lgtm

[Yusuf, 2016-10-11 22:28:48]

lgtm

[Ted C, 2016-10-11 23:38:58]

https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
(right):

https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java:76:
CriteriaHelper.pollUiThread(new Criteria() {
On 2016/10/11 21:48:16, Maria wrote:
> why do we need to poll UI thread for this? I thought the idea of having
> createdCct set as an atomic reference was to have the state reflected across
> threads?

Very true.  I copied this from other places that expect to bounce through the
launcher activity.  Since i'm using createCustomTabActivityIntent, it will go
directly to the CCT and reduce the noise here.

Very good point.  In particular, it highlights that maybe we are doing
inefficient things for many of our tests.  ChromeActivityTestCaseBase specifies
the launcher as the component so all of our tests are making that hop.  We
should probably remove that and only do that for tests that truly should be
testing the interactions there.

https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java:155:
public boolean isSatisfied() {
On 2016/10/11 21:48:16, Maria wrote:
> Hmm, do we restart everything on per-testcase or per test basis? I wonder if
you
> switching to a different app would cause the other testcase not to run
properly
> if it ran after this one.

Switched the ordering and it ran (tried both the rename and file ordering).

[Ted C, 2016-10-11 23:39:21]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-10-11 23:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2405343002/#ps20001
(title: "Cleanup activity startup code")

[commit-bot: I haz the power, 2016-10-11 23:39:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 00:51:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 00:53:35]

Description was changed from

==========
Add tests for native app redirects in herb.

BUG=653254
==========

to

==========
Add tests for native app redirects in herb.

BUG=653254

Committed: https://crrev.com/680a1d0d69eb542dfbe8131d5bab49db6ce26271
Cr-Commit-Position: refs/heads/master@{#424619}
==========

[commit-bot: I haz the power, 2016-10-12 00:53:35]

Patchset 2 (id:??) landed as
https://crrev.com/680a1d0d69eb542dfbe8131d5bab49db6ce26271
Cr-Commit-Position: refs/heads/master@{#424619}