Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2405343002: Add tests for native app redirects in herb. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
Yusuf, Maria
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for native app redirects in herb. BUG=653254 Committed: https://crrev.com/680a1d0d69eb542dfbe8131d5bab49db6ce26271 Cr-Commit-Position: refs/heads/master@{#424619}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cleanup activity startup code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java View 1 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ted C
PTAL
4 years, 2 months ago (2016-10-11 19:40:26 UTC) #2
Maria
https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java (right): https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java#newcode76 chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java:76: CriteriaHelper.pollUiThread(new Criteria() { why do we need to poll ...
4 years, 2 months ago (2016-10-11 21:48:16 UTC) #3
Maria
lgtm
4 years, 2 months ago (2016-10-11 22:16:54 UTC) #4
Yusuf
lgtm
4 years, 2 months ago (2016-10-11 22:28:48 UTC) #5
Ted C
https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java (right): https://codereview.chromium.org/2405343002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java#newcode76 chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java:76: CriteriaHelper.pollUiThread(new Criteria() { On 2016/10/11 21:48:16, Maria wrote: > ...
4 years, 2 months ago (2016-10-11 23:38:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405343002/20001
4 years, 2 months ago (2016-10-11 23:39:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 00:51:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 00:53:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/680a1d0d69eb542dfbe8131d5bab49db6ce26271
Cr-Commit-Position: refs/heads/master@{#424619}

Powered by Google App Engine
This is Rietveld 408576698