Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2405313002: [modules] Store Module metadata in per-Context EmbedderData (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Store Module metadata in per-Context EmbedderData This is a re-land of https://codereview.chromium.org/2393303002/ with an additional call to DisposeModuleEmbedderData() added to fix lsan failures. Unifies the approaches used for storing the specifier -> module mapping and the module -> directory mapping, using std::unordered_maps for both and storing them per-Context. This requires adding a method to the v8::Module API to get a hash code for a Module, but allows slimming down the API in return: gone are SetEmbedderData/GetEmbedderData, along with the fourth argument to ResolveModuleCallback. Besides a simpler API, this allows d8 to get closer to the HTML loader, which requires each Realm to have a persistent module map (though this capability is not yet exercised by any tests). BUG=v8:1569 TBR=neis@chromium.org,jochen@chromium.org Committed: https://crrev.com/9d2051fc2896bcb771cfb41b2864601c6c40e299 Cr-Commit-Position: refs/heads/master@{#40186}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -95 lines) Patch
M include/v8.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M src/d8.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/d8.cc View 1 2 12 chunks +92 lines, -37 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-modules.cc View 3 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405313002/40001
4 years, 2 months ago (2016-10-11 18:25:35 UTC) #2
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 19:22:11 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:22:34 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9d2051fc2896bcb771cfb41b2864601c6c40e299
Cr-Commit-Position: refs/heads/master@{#40186}

Powered by Google App Engine
This is Rietveld 408576698