Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2405303002: [inspector] expose js_protocol.json file location in BUILD file (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] expose js_protocol.json file location in BUILD file This location is used at least in Chromium. BUG=chromium:635948 R=dgozman@chromium.org Committed: https://crrev.com/2c37e4a0f1f275a24013f2b36c67c851721fdde2 Cr-Commit-Position: refs/heads/master@{#40225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M gni/v8.gni View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kozy
Dmitry, please take a look. This variable is accessible from BUILD.gn in Source/core/inspector if import("//v8/gni/v8.gni") ...
4 years, 2 months ago (2016-10-11 18:15:10 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-11 19:38:28 UTC) #2
kozy
Yang, please take a look.
4 years, 2 months ago (2016-10-11 20:05:31 UTC) #4
Yang
On 2016/10/11 20:05:31, kozyatinskiy wrote: > Yang, please take a look. lgtm.
4 years, 2 months ago (2016-10-12 09:09:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405303002/1
4 years, 2 months ago (2016-10-12 13:46:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 14:11:04 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 14:11:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c37e4a0f1f275a24013f2b36c67c851721fdde2
Cr-Commit-Position: refs/heads/master@{#40225}

Powered by Google App Engine
This is Rietveld 408576698