Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1869)

Unified Diff: Source/core/scripts/action_derivedsourcesallinone.py

Issue 24053003: Support partial interface for test support idls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove hardcoding Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/scripts/action_derivedsourcesallinone.py
diff --git a/Source/core/scripts/action_derivedsourcesallinone.py b/Source/core/scripts/action_derivedsourcesallinone.py
index fec5088917a9e24775662d03a2aa2a5b268422d1..11014f6efc83c5ab6b78153150e925ac6f09c2b3 100644
--- a/Source/core/scripts/action_derivedsourcesallinone.py
+++ b/Source/core/scripts/action_derivedsourcesallinone.py
@@ -198,19 +198,19 @@ def main(args):
inputFileName = args[1]
outputFileNames = args[inOutBreakIndex+1:]
- inputFile = open(inputFileName, 'r')
idlFileNames = []
cygdriveNames = []
- for line in inputFile:
- idlFileName = line.rstrip().split(' ')[0]
- if idlFileName.startswith("/cygdrive"):
- cygdriveNames.append(idlFileName)
- else:
- idlFileNames.append(idlFileName)
+ with open(inputFileName) as inputFile:
+ for line in inputFile:
+ idlFileName = line.rstrip()
+ if idlFileName.startswith('/cygdrive'):
+ cygdriveNames.append(idlFileName)
+ else:
+ idlFileNames.append(idlFileName)
+ inputFile.close()
if cygdriveNames:
idlFileNames.extend(resolveCygpath(cygdriveNames))
- inputFile.close()
filesMetaData = extractMetaData(idlFileNames)
for fileName in outputFileNames:

Powered by Google App Engine
This is Rietveld 408576698