Chromium Code Reviews| Index: Source/build/scripts/action_derivedsourcesallinone.py |
| diff --git a/Source/build/scripts/action_derivedsourcesallinone.py b/Source/build/scripts/action_derivedsourcesallinone.py |
| index fec5088917a9e24775662d03a2aa2a5b268422d1..75729fe1b7873c3a055be46ecc8abebb1dc78306 100644 |
| --- a/Source/build/scripts/action_derivedsourcesallinone.py |
| +++ b/Source/build/scripts/action_derivedsourcesallinone.py |
| @@ -198,19 +198,18 @@ def main(args): |
| inputFileName = args[1] |
| outputFileNames = args[inOutBreakIndex+1:] |
| - inputFile = open(inputFileName, 'r') |
| idlFileNames = [] |
| cygdriveNames = [] |
| - for line in inputFile: |
| - idlFileName = line.rstrip().split(' ')[0] |
| - if idlFileName.startswith("/cygdrive"): |
| - cygdriveNames.append(idlFileName) |
| - else: |
| - idlFileNames.append(idlFileName) |
| + with open(inputFileName) as inputFile: |
|
eseidel
2013/10/10 06:08:37
Woh, cxrazy this is no pep8, but I guess chromium
Nils Barth (inactive)
2013/10/10 06:17:34
Nono, you're right, this should be under_scores:
h
Nils Barth (inactive)
2013/10/10 08:51:02
Python style (and bug fix!) for this file addresse
|
| + for line in inputFile: |
| + idlFileName = line.rstrip() |
| + if idlFileName.startswith('/cygdrive'): |
|
eseidel
2013/10/10 06:08:37
Bleh. Filesystem abstractions ftw.
|
| + cygdriveNames.append(idlFileName) |
| + else: |
| + idlFileNames.append(idlFileName) |
| if cygdriveNames: |
| idlFileNames.extend(resolveCygpath(cygdriveNames)) |
| - inputFile.close() |
| filesMetaData = extractMetaData(idlFileNames) |
| for fileName in outputFileNames: |