Chromium Code Reviews| Index: Source/core/scripts/action_derivedsourcesallinone.py |
| diff --git a/Source/core/scripts/action_derivedsourcesallinone.py b/Source/core/scripts/action_derivedsourcesallinone.py |
| index fec5088917a9e24775662d03a2aa2a5b268422d1..11014f6efc83c5ab6b78153150e925ac6f09c2b3 100644 |
| --- a/Source/core/scripts/action_derivedsourcesallinone.py |
| +++ b/Source/core/scripts/action_derivedsourcesallinone.py |
| @@ -198,19 +198,19 @@ def main(args): |
| inputFileName = args[1] |
| outputFileNames = args[inOutBreakIndex+1:] |
| - inputFile = open(inputFileName, 'r') |
| idlFileNames = [] |
| cygdriveNames = [] |
| - for line in inputFile: |
| - idlFileName = line.rstrip().split(' ')[0] |
| - if idlFileName.startswith("/cygdrive"): |
| - cygdriveNames.append(idlFileName) |
| - else: |
| - idlFileNames.append(idlFileName) |
| + with open(inputFileName) as inputFile: |
| + for line in inputFile: |
| + idlFileName = line.rstrip() |
| + if idlFileName.startswith('/cygdrive'): |
| + cygdriveNames.append(idlFileName) |
| + else: |
| + idlFileNames.append(idlFileName) |
| + inputFile.close() |
|
Nils Barth (inactive)
2013/10/08 02:11:18
Could you remove inputFile.close() ?
(It's not nee
kihong
2013/10/10 04:33:57
Done.
|
| if cygdriveNames: |
| idlFileNames.extend(resolveCygpath(cygdriveNames)) |
| - inputFile.close() |
| filesMetaData = extractMetaData(idlFileNames) |
| for fileName in outputFileNames: |