Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 24053003: Support partial interface for test support idls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use one InterfaceDependencies.txt file Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index 80d8dc6a23a449c23061cb8e48ef9792dec2cdcd..b67673d8353e4e91712df5a2d1de837b0a72b61a 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -53,6 +53,7 @@ SKIP_PYTHON = set([
])
input_directory = os.path.join('bindings', 'tests', 'idls')
+testing_input_directory = os.path.join('bindings', 'tests', 'idls', 'testing')
reference_directory = os.path.join('bindings', 'tests', 'results')
reference_event_names_filename = os.path.join(reference_directory, 'EventInterfaces.in')
@@ -140,6 +141,11 @@ class BindingsTests(object):
if input_file.endswith('.idl')]
idl_files_list_contents = ''.join(idl_path + '\n'
for idl_path in idl_paths)
+ testing_idl_paths = [os.path.join(testing_input_directory, input_file)
+ for input_file in os.listdir(testing_input_directory)
+ if input_file.endswith('.idl')]
+ idl_files_list_contents = idl_files_list_contents.join(idl_path + '\n'
+ for idl_path in testing_idl_paths)
os.write(idl_files_list_file, idl_files_list_contents)
# Dummy files, required by compute_dependencies but not checked
@@ -199,7 +205,7 @@ class BindingsTests(object):
for (reference_filename, work_filename) in file_pairs])
def run_tests(self):
- def generate_and_check_output_pl(idl_filename):
+ def generate_and_check_output_pl(idl_filename, input_directory):
# Generate output into the reference directory if resetting
# results, or a temp directory if not.
if self.reset_results:
@@ -230,9 +236,12 @@ class BindingsTests(object):
else:
passed = self.identical_file(reference_event_names_filename,
self.event_names_filename)
- passed &= all([generate_and_check_output_pl(input_file)
+ passed &= all([generate_and_check_output_pl(input_file, input_directory)
for input_file in os.listdir(input_directory)
if input_file.endswith('.idl')])
+ passed &= all([generate_and_check_output_pl(input_file, testing_input_directory)
+ for input_file in os.listdir(testing_input_directory)
+ if input_file.endswith('.idl')])
print
print 'Python:'
passed &= all([generate_and_check_output_py(input_file)

Powered by Google App Engine
This is Rietveld 408576698