Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: Source/bindings/scripts/compute_dependencies.py

Issue 24053003: Support partial interface for test support idls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use one InterfaceDependencies.txt file Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/compute_dependencies.py
diff --git a/Source/bindings/scripts/compute_dependencies.py b/Source/bindings/scripts/compute_dependencies.py
index 816b5b237dab754b87f9915967abad33fb62d5bd..c2c0a825382ba4ece8597cfee09b79a88fa800db 100755
--- a/Source/bindings/scripts/compute_dependencies.py
+++ b/Source/bindings/scripts/compute_dependencies.py
@@ -259,20 +259,21 @@ def parse_idl_files(idl_files, global_constructors_filenames):
implements_interfaces[interface_name] = implemented_interfaces
implemented_somewhere |= set(implemented_interfaces)
- # Record global constructors
- if not is_callback_interface_from_idl(idl_file_contents) and 'NoInterfaceObject' not in extended_attributes:
- global_contexts = extended_attributes.get('GlobalContext', 'Window').split('&')
- new_constructor_list = generate_constructor_attribute_list(interface_name, extended_attributes)
- for global_object in global_contexts:
- global_constructors[global_object].extend(new_constructor_list)
-
- # Record parents and extended attributes for generating event names
- if interface_name == 'Event':
- interface_extended_attribute[interface_name] = extended_attributes
- parent = get_parent_interface(idl_file_contents)
- if parent:
- parent_interface[interface_name] = parent
- interface_extended_attribute[interface_name] = extended_attributes
+ if idl_file_name.find('testing') == -1:
+ # Record global constructors
+ if not is_callback_interface_from_idl(idl_file_contents) and 'NoInterfaceObject' not in extended_attributes:
+ global_contexts = extended_attributes.get('GlobalContext', 'Window').split('&')
+ new_constructor_list = generate_constructor_attribute_list(interface_name, extended_attributes)
+ for global_object in global_contexts:
+ global_constructors[global_object].extend(new_constructor_list)
+
+ # Record parents and extended attributes for generating event names
+ if interface_name == 'Event':
+ interface_extended_attribute[interface_name] = extended_attributes
+ parent = get_parent_interface(idl_file_contents)
+ if parent:
+ parent_interface[interface_name] = parent
+ interface_extended_attribute[interface_name] = extended_attributes
# Add constructors on global objects to partial interfaces
for global_object, filename in global_constructors_filenames.iteritems():

Powered by Google App Engine
This is Rietveld 408576698