src/heap/objects-visiting.cc - Issue 2405253006: [builtins] implement Array.prototype[@@iterator] in TFJ builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting.cc

Issue 2405253006: [builtins] implement Array.prototype[@@iterator] in TFJ builtins (Closed)

Patch Set: add array_iterator_protector, and check array_protector in holey fast arrays Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/objects-visiting.cc

diff --git a/src/heap/objects-visiting.cc b/src/heap/objects-visiting.cc

index 742ac854fb1f41309376fe3ade11ff403d071bd2..70a8af514a8841443071cbaf37167b9232a53453 100644

--- a/src/heap/objects-visiting.cc

+++ b/src/heap/objects-visiting.cc

@@ -122,6 +122,42 @@ StaticVisitorBase::VisitorId StaticVisitorBase::GetVisitorId(

case JS_SET_ITERATOR_TYPE:

case JS_MAP_ITERATOR_TYPE:

case JS_STRING_ITERATOR_TYPE:

+ case JS_TYPED_ARRAY_KEY_ITERATOR_TYPE:

+ case JS_GENERIC_ARRAY_KEY_ITERATOR_TYPE:

+ case JS_UINT8_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_INT8_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_UINT16_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_INT16_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_UINT32_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_INT32_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FLOAT32_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FLOAT64_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_UINT8_CLAMPED_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_SMI_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_HOLEY_SMI_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_HOLEY_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_DOUBLE_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_HOLEY_DOUBLE_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_GENERIC_ARRAY_KEY_VALUE_ITERATOR_TYPE:

+ case JS_UINT8_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_INT8_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_UINT16_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_INT16_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_UINT32_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_INT32_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FLOAT32_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FLOAT64_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_UINT8_CLAMPED_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_SMI_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_HOLEY_SMI_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_HOLEY_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_FAST_HOLEY_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE:

+ case JS_GENERIC_ARRAY_VALUE_ITERATOR_TYPE:

case JS_PROMISE_TYPE:

case JS_BOUND_FUNCTION_TYPE:

return GetVisitorIdForSize(kVisitJSObject, kVisitJSObjectGeneric,

« src/builtins/builtins-array.cc ('K') | « src/heap/heap.cc ('k') | src/isolate.h » ('j') | no next file with comments »