Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: src/builtins/builtins.cc

Issue 2405253006: [builtins] implement Array.prototype[@@iterator] in TFJ builtins (Closed)
Patch Set: fix JSArrayIteratorVerify() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 #include "src/code-events.h" 6 #include "src/code-events.h"
7 #include "src/code-stub-assembler.h" 7 #include "src/code-stub-assembler.h"
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 #include "src/isolate.h" 10 #include "src/isolate.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 } 79 }
80 80
81 // Builder for builtins implemented in TurboFan with JS linkage. 81 // Builder for builtins implemented in TurboFan with JS linkage.
82 Code* BuildWithCodeStubAssemblerJS(Isolate* isolate, 82 Code* BuildWithCodeStubAssemblerJS(Isolate* isolate,
83 CodeAssemblerGenerator generator, int argc, 83 CodeAssemblerGenerator generator, int argc,
84 Code::Flags flags, const char* name) { 84 Code::Flags flags, const char* name) {
85 HandleScope scope(isolate); 85 HandleScope scope(isolate);
86 Zone zone(isolate->allocator()); 86 Zone zone(isolate->allocator());
87 CodeStubAssembler assembler(isolate, &zone, argc, flags, name); 87 CodeStubAssembler assembler(isolate, &zone, argc, flags, name);
88 generator(&assembler); 88 generator(&assembler);
89 if (!::strcmp(name, "ArrayIteratorPrototypeNext")) {
Benedikt Meurer 2016/10/17 04:02:42 Please remove this left over test code.
caitp 2016/10/18 00:16:50 Done :x
90 int x = 5;
91 USE(x);
92 }
89 Handle<Code> code = assembler.GenerateCode(); 93 Handle<Code> code = assembler.GenerateCode();
90 PostBuildProfileAndTracing(isolate, *code, name); 94 PostBuildProfileAndTracing(isolate, *code, name);
91 return *code; 95 return *code;
92 } 96 }
93 97
94 // Builder for builtins implemented in TurboFan with CallStub linkage. 98 // Builder for builtins implemented in TurboFan with CallStub linkage.
95 Code* BuildWithCodeStubAssemblerCS(Isolate* isolate, 99 Code* BuildWithCodeStubAssemblerCS(Isolate* isolate,
96 CodeAssemblerGenerator generator, 100 CodeAssemblerGenerator generator,
97 CallDescriptors::Key interface_descriptor, 101 CallDescriptors::Key interface_descriptor,
98 Code::Flags flags, const char* name) { 102 Code::Flags flags, const char* name) {
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 // TODO(jochen): Remove this. 290 // TODO(jochen): Remove this.
287 if (responsible_context.is_null()) { 291 if (responsible_context.is_null()) {
288 return true; 292 return true;
289 } 293 }
290 if (*responsible_context == target->context()) return true; 294 if (*responsible_context == target->context()) return true;
291 return isolate->MayAccess(responsible_context, target_global_proxy); 295 return isolate->MayAccess(responsible_context, target_global_proxy);
292 } 296 }
293 297
294 } // namespace internal 298 } // namespace internal
295 } // namespace v8 299 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698