Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 2405253003: Revert of [Chromoting] Reenable 64-bit build checks for Windows (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Reenable 64-bit build checks for Windows (patchset #1 id:1 of https://codereview.chromium.org/2403923003/ ) Reason for revert: Speculative revert for possibly causing a failure of official build. See crbug.com/654818 Original issue's description: > [Chromoting] Reenable 64-bit build checks for Windows > > After discussing with team members, we prefer to keep generating 64 bit host archive. > > BUG=623077 > > TBR=mmoss@chromium.org > > Committed: https://crrev.com/c262ad93cafd49ced3e82bc907b6fe0a042b6a59 > Cr-Commit-Position: refs/heads/master@{#424314} TBR=joedow@chromium.org,mmoss@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623077 Committed: https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 Cr-Commit-Position: refs/heads/master@{#424503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alph
Created Revert of [Chromoting] Reenable 64-bit build checks for Windows
4 years, 2 months ago (2016-10-11 19:03:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405253003/1
4 years, 2 months ago (2016-10-11 19:04:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 19:06:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0863beb9eecda857d9dd79e653d5975b53ebf8c1 Cr-Commit-Position: refs/heads/master@{#424503}
4 years, 2 months ago (2016-10-11 19:10:43 UTC) #6
Michael Moss
lgtm
4 years, 2 months ago (2016-10-11 19:12:28 UTC) #7
Hzj_jie
4 years, 2 months ago (2016-10-11 23:18:27 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2405413002/ by zijiehe@chromium.org.

The reason for reverting is: Resubmit original change
https://codereview.chromium.org/2403923003/..

Powered by Google App Engine
This is Rietveld 408576698