Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: base/task_scheduler/delayed_task_manager.h

Issue 2405243003: TaskScheduler: Replace the SchedulerServiceThread with a base::Thread. (Closed)
Patch Set: CR robliao #9 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/delayed_task_manager.h
diff --git a/base/task_scheduler/delayed_task_manager.h b/base/task_scheduler/delayed_task_manager.h
index d773fe5da9413e478af6cf85f67792496f0b8f44..3bfb355ef6dc0e31d2f7c1d9be4e45f94d7c41fe 100644
--- a/base/task_scheduler/delayed_task_manager.h
+++ b/base/task_scheduler/delayed_task_manager.h
@@ -5,40 +5,37 @@
#ifndef BASE_TASK_SCHEDULER_DELAYED_TASK_MANAGER_H_
#define BASE_TASK_SCHEDULER_DELAYED_TASK_MANAGER_H_
-#include <stdint.h>
-
#include <memory>
-#include <queue>
-#include <vector>
#include "base/base_export.h"
-#include "base/callback.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "base/task_scheduler/scheduler_lock.h"
-#include "base/task_scheduler/sequence.h"
-#include "base/task_scheduler/task.h"
#include "base/time/time.h"
namespace base {
+
+class TaskRunner;
+
namespace internal {
class SchedulerWorker;
class SchedulerWorkerPool;
+class Sequence;
+struct Task;
-// A DelayedTaskManager holds delayed Tasks until they become ripe for
-// execution. This class is thread-safe.
+// A DelayedTaskManager forwards Tasks to a SchedulerWorkerPool when they become
+// ripe for execution. This class is thread-safe.
class BASE_EXPORT DelayedTaskManager {
public:
- // |on_delayed_run_time_updated| is invoked when the delayed run time is
- // updated as a result of adding a delayed task to the manager.
- explicit DelayedTaskManager(const Closure& on_delayed_run_time_updated);
+ // |service_thread_task_runner| posts tasks to the TaskScheduler service
+ // thread.
+ explicit DelayedTaskManager(
+ scoped_refptr<TaskRunner> service_thread_task_runner);
~DelayedTaskManager();
- // Adds |task| to a queue of delayed tasks. The task will be posted to
- // |worker_pool| with |sequence| and |worker| the first time that
- // PostReadyTasks() is called while Now() is passed |task->delayed_run_time|.
- // |worker| is a SchedulerWorker owned by |worker_pool| or nullptr.
+ // Posts |task|. The task will be forwarded to |worker_pool| with |sequence|
+ // and |worker| when it becomes ripe for execution. |worker| is a
+ // SchedulerWorker owned by |worker_pool| or nullptr.
//
// TODO(robliao): Find a concrete way to manage the memory of |worker| and
// |worker_pool|. These objects are never deleted in production, but it is
@@ -48,36 +45,8 @@ class BASE_EXPORT DelayedTaskManager {
SchedulerWorker* worker,
SchedulerWorkerPool* worker_pool);
- // Posts delayed tasks that are ripe for execution.
- void PostReadyTasks();
-
- // Returns the next time at which a delayed task will become ripe for
- // execution, or a null TimeTicks if there are no pending delayed tasks.
- TimeTicks GetDelayedRunTime() const;
-
- // Returns the current time. Can be overridden for tests.
- virtual TimeTicks Now() const;
-
private:
- struct DelayedTask;
- struct DelayedTaskComparator {
- bool operator()(const DelayedTask& left, const DelayedTask& right) const;
- };
-
- const Closure on_delayed_run_time_updated_;
-
- // Synchronizes access to all members below.
- mutable SchedulerLock lock_;
-
- // Priority queue of delayed tasks. The delayed task with the smallest
- // |task->delayed_run_time| is in front of the priority queue.
- using DelayedTaskQueue = std::priority_queue<DelayedTask,
- std::vector<DelayedTask>,
- DelayedTaskComparator>;
- DelayedTaskQueue delayed_tasks_;
-
- // The index to assign to the next delayed task added to the manager.
- uint64_t delayed_task_index_ = 0;
+ const scoped_refptr<TaskRunner> service_thread_task_runner_;
DISALLOW_COPY_AND_ASSIGN(DelayedTaskManager);
};

Powered by Google App Engine
This is Rietveld 408576698