Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2405243002: [build] Use static libraries on x87 bot. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Use static libraries on x87 bot. The bot currently doesn't work with shared libraries. This temporarily works around the problem to get the bot green. BUG=v8:5412 NOTRY=true TBR=jochen, zhengxing.li, jgruber Committed: https://crrev.com/af190288640ed7dceb9e79b68276d7b8763470cc Cr-Commit-Position: refs/heads/master@{#40191}

Patch Set 1 #

Patch Set 2 : [build] Use static libraries on x87 bot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M infra/mb/mb_config.pyl View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Michael Achenbach
PTAL. Currently fails with errors like: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20x87%20-%20nosnap%20-%20debug/builds/1015/steps/Check/logs/regress-1493017 Even though libicui18n.so is in the uploaded isolate: ...
4 years, 2 months ago (2016-10-11 12:20:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405243002/20001
4 years, 2 months ago (2016-10-12 06:47:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 06:49:38 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 06:50:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af190288640ed7dceb9e79b68276d7b8763470cc
Cr-Commit-Position: refs/heads/master@{#40191}

Powered by Google App Engine
This is Rietveld 408576698