Add test to make sure if PPB_Audio_Shared::StartThread() works.

ppapi/proxy/ppb_audio_proxy.cc

Index: ppapi/proxy/ppb_audio_proxy.cc
diff --git a/ppapi/proxy/ppb_audio_proxy.cc b/ppapi/proxy/ppb_audio_proxy.cc
index 58f5abc0d4141f747e3a2845dd1682ccfc4388ff..3eb8dc46059868af44d11223f556de9da2a7e862 100644
--- a/ppapi/proxy/ppb_audio_proxy.cc
+++ b/ppapi/proxy/ppb_audio_proxy.cc
@@ -95,7 +95,8 @@ PP_Resource Audio::GetCurrentConfig() {
 PP_Bool Audio::StartPlayback() {
   if (playing())
     return PP_TRUE;
-  SetStartPlaybackState();
+  if (!SetStartPlaybackState())
+    return PP_FALSE;

[bbudge, 2014/04/18 13:27:25]

Could you check the thread creation hooks here instead of in
SetStartPlaybackState. I think that could be a lot simpler.

[bbudge, 2014/04/18 13:34:40]

Never mind, I see that those hooks are part of the shared object, so you have to
test them there.

[bbudge, 2014/04/18 15:08:08]

Another thought: add a protected method to the PPB_AudioShared that tests
whether the hooks were set. You could call it here. The SetStartPlaybackState
and StartThread methods are already complicated, so I'd like to avoid this
return value. WDYT?

[hidehiko, 2014/04/18 18:16:30]

I like your idea. How about this?


On 2014/04/18 15:08:08, bbudge wrote:

   PluginDispatcher::GetForResource(this)->Send(
       new PpapiHostMsg_PPBAudio_StartOrStop(
           API_ID_PPB_AUDIO, host_resource(), true));