Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2405203002: [stubs] Simplify the ArrayConstructorStub. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Simplify the ArrayConstructorStub. Remove the special side channel from the CallICStub to the ArrayConstructorStub and make the CallICStub always use the general entry point. R=yangguo@chromium.org Committed: https://crrev.com/9192db20370ad43954455007dc808b04dbff498b Cr-Commit-Position: refs/heads/master@{#40162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -318 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +17 lines, -42 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +20 lines, -45 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +1 line, -37 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +17 lines, -44 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +18 lines, -43 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +18 lines, -43 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +19 lines, -52 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-11 08:26:53 UTC) #1
Yang
On 2016/10/11 08:26:53, Benedikt Meurer wrote: lgtm.
4 years, 2 months ago (2016-10-11 11:11:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405203002/1
4 years, 2 months ago (2016-10-11 11:15:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 11:17:50 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 11:18:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9192db20370ad43954455007dc808b04dbff498b
Cr-Commit-Position: refs/heads/master@{#40162}

Powered by Google App Engine
This is Rietveld 408576698