Issue 24052003: Check that AllocationMementos never get scavengend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24052003: Check that AllocationMementos never get scavengend. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)

Modified:
7 years, 3 months ago

Reviewers:
mvstanton, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check that AllocationMementos never get scavengend. BUG= R=mstarzinger@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16628

Patch Set 4 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/heap-inl.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mvstanton

one comment and lgtm. thanks Hannes! https://codereview.chromium.org/24052003/diff/5001/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/24052003/diff/5001/src/heap-inl.h#newcode529 src/heap-inl.h:529: CHECK(object->map() != object->GetHeap()->allocation_memento_map()); ...

7 years, 3 months ago (2013-09-10 15:42:30 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/24052003/diff/5001/src/heap-inl.h File src/heap-inl.h (right): https://codereview.chromium.org/24052003/diff/5001/src/heap-inl.h#newcode529 src/heap-inl.h:529: CHECK(object->map() != object->GetHeap()->allocation_memento_map()); On 2013/09/10 15:42:30, mvstanton wrote: > ...

7 years, 3 months ago (2013-09-10 17:21:52 UTC) #4

Hannes Payer (out of office)

7 years, 3 months ago (2013-09-10 17:29:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r16628.

Expand Messages | Collapse Messages

Issue 24052003: Check that AllocationMementos never get scavengend. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages