Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: trunk/src/apps/app_shim/app_shim_host_manager_mac.h

Issue 24052002: Revert 221580 "Make AppShimHostManager a RefCountedThreadSafe." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/apps/app_shim/app_shim_host_manager_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/apps/app_shim/app_shim_host_manager_mac.h
===================================================================
--- trunk/src/apps/app_shim/app_shim_host_manager_mac.h (revision 221792)
+++ trunk/src/apps/app_shim/app_shim_host_manager_mac.h (working copy)
@@ -6,25 +6,23 @@
#define CHROME_BROWSER_WEB_APPLICATIONS_APP_SHIM_HOST_MANAGER_MAC_H_
#include "apps/app_shim/extension_app_shim_handler_mac.h"
-#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
#include "ipc/ipc_channel_factory.h"
// The AppShimHostManager receives connections from app shims on a UNIX
// socket (|factory_|) and creates a helper object to manage the connection.
class AppShimHostManager
: public IPC::ChannelFactory::Delegate,
- public base::RefCountedThreadSafe<AppShimHostManager> {
+ public base::SupportsWeakPtr<AppShimHostManager> {
public:
AppShimHostManager();
+ virtual ~AppShimHostManager();
apps::ExtensionAppShimHandler* extension_app_shim_handler() {
return &extension_app_shim_handler_;
}
private:
- friend class base::RefCountedThreadSafe<AppShimHostManager>;
- virtual ~AppShimHostManager();
-
// IPC::ChannelFactory::Delegate implementation.
virtual void OnClientConnected(const IPC::ChannelHandle& handle) OVERRIDE;
virtual void OnListenError() OVERRIDE;
« no previous file with comments | « no previous file | trunk/src/apps/app_shim/app_shim_host_manager_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698