Issue 24052002: Revert 221580 "Make AppShimHostManager a RefCountedThreadSafe."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24052002: Revert 221580 "Make AppShimHostManager a RefCountedThreadSafe." (Closed)

Created:
7 years, 3 months ago by Raghu Simha

Modified:
7 years, 3 months ago

Reviewers:
jackhou1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 221580 "Make AppShimHostManager a RefCountedThreadSafe." Reason for revert: Use-after-free heap errors caught by asan. See bug 286483. > Make AppShimHostManager a RefCountedThreadSafe. > > This prevents a crash when Chrome shuts down immediately and > AppShimHostManager is destructed before InitOnFileThread is run. > Note this means AppShimHostManager can stay around longer than > BrowserProcessPlatformPart during initialization. > > Review URL: https://chromiumcodereview.appspot.com/20065004 BUG=286483, 242941 TBR=jackhou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221793

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	trunk/src/apps/app_shim/app_shim_host_manager_mac.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	trunk/src/apps/app_shim/app_shim_host_manager_mac.mm	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_platform_part_mac.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/browser_process_platform_part_mac.mm	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r221793.

Expand Messages | Collapse Messages