Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2405193004: Extend ignore_patch_signature_mismatch used by dartium to ignore type parameters with different bou… (Closed)

Created:
4 years, 2 months ago by Jacob
Modified:
4 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extend ignore_patch_signature_mismatch used by dartium to ignore type parameters with different bounds BUG=https://github.com/dart-lang/sdk/issues/27568 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/72503ff98d63f8934396118bb1f560ffef3ff6c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +32 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jacob314
Dartium uses this flag to simplify patch file generation for JS interop. Note that Dartium ...
4 years, 2 months ago (2016-10-11 17:22:30 UTC) #2
jacob314
This fixes https://github.com/dart-lang/sdk/issues/27568
4 years, 2 months ago (2016-10-11 17:30:47 UTC) #3
siva
lgtm
4 years, 2 months ago (2016-10-13 00:04:22 UTC) #7
Jacob
4 years, 2 months ago (2016-10-13 00:26:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72503ff98d63f8934396118bb1f560ffef3ff6c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698