Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2405173003: Revert of Remove SVN and File support from gclient (Closed)

Created:
4 years, 2 months ago by lpique
Modified:
4 years, 2 months ago
Reviewers:
agable, M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Remove SVN and File support from gclient (patchset #4 id:60001 of https://codereview.chromium.org/2398493004/ ) Reason for revert: The Chrome buildbots pass "--transitive" still. Removing the option causes them to fail to build. Example: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/21555 Original issue's description: > Remove SVN and File support from gclient > > FileImpl was only usable with SVN. > > R=maruel@chromium.org > BUG=641588 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd5159972f58063967a9c07ef724ff97b TBR=maruel@chromium.org,agable@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641588 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/398a46ee099e74ee5c8f4550eb6eb48899fbe863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -95 lines) Patch
M gclient.py View 27 chunks +293 lines, -94 lines 0 comments Download
M gclient_scm.py View 3 chunks +18 lines, -0 lines 0 comments Download
M tests/gclient_test.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
lpique
Created Revert of Remove SVN and File support from gclient
4 years, 2 months ago (2016-10-11 20:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405173003/1
4 years, 2 months ago (2016-10-11 20:16:31 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-11 20:16:33 UTC) #5
agable
lgtm
4 years, 2 months ago (2016-10-11 20:19:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405173003/1
4 years, 2 months ago (2016-10-11 20:19:52 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 20:20:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/398a46ee099e74...

Powered by Google App Engine
This is Rietveld 408576698