Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: src/wasm/wasm-module.cc

Issue 2405173002: [wasm] Use WasmCompiledModule type in interfaces (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index 5f7174acebac77a6c4662b9134c628c85e28618a..f215f851762bd40bcf8538b9ac5a54c1c8059172 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -2093,9 +2093,9 @@ int GetNumberOfFunctions(Handle<JSObject> wasm) {
return func_names_arr->get_int(0);
}
-Handle<JSObject> CreateCompiledModuleObject(Isolate* isolate,
- Handle<FixedArray> compiled_module,
- ModuleOrigin origin) {
+Handle<JSObject> CreateCompiledModuleObject(
+ Isolate* isolate, Handle<WasmCompiledModule> compiled_module,
+ ModuleOrigin origin) {
Handle<JSObject> module_obj;
if (origin == ModuleOrigin::kWasmOrigin) {
Handle<JSFunction> module_cons(
@@ -2113,8 +2113,7 @@ Handle<JSObject> CreateCompiledModuleObject(Isolate* isolate,
Object::SetProperty(module_obj, module_sym, module_obj, STRICT).Check();
}
Handle<WeakCell> link_to_module = isolate->factory()->NewWeakCell(module_obj);
- WasmCompiledModule::cast(*compiled_module)
- ->set_weak_module_object(link_to_module);
+ compiled_module->set_weak_module_object(link_to_module);
return module_obj;
}
@@ -2132,7 +2131,7 @@ MaybeHandle<JSObject> CreateModuleObjectFromBytes(Isolate* isolate,
thrower->Failed("Wasm decoding failed", result);
return nothing;
}
- MaybeHandle<FixedArray> compiled_module =
+ MaybeHandle<WasmCompiledModule> compiled_module =
decoded_module->CompileFunctions(isolate, thrower);
if (compiled_module.is_null()) return nothing;

Powered by Google App Engine
This is Rietveld 408576698