Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2405173002: [wasm] Use WasmCompiledModule type in interfaces (Closed)

Created:
4 years, 2 months ago by Clemens Hammacher
Modified:
4 years, 2 months ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use WasmCompiledModule type in interfaces Just a minor refactoring. We have the type for compiled modules, so use it where possible for better type safety. R=ahaas@chromium.org, titzer@chromium.org Committed: https://crrev.com/1b5861413597a2f9dfec98e9bebc0fad457f726d Cr-Commit-Position: refs/heads/master@{#40156}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/runtime/runtime-test.cc View 1 chunk +3 lines, -2 lines 2 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
ahaas
lgtm with nit https://codereview.chromium.org/2405173002/diff/20001/src/runtime/runtime-test.cc File src/runtime/runtime-test.cc (right): https://codereview.chromium.org/2405173002/diff/20001/src/runtime/runtime-test.cc#newcode766 src/runtime/runtime-test.cc:766: WasmCompiledModuleSerializer::DeserializeWasmModule(isolate, &sc); Couldn't DeserializeWasmModule already return ...
4 years, 2 months ago (2016-10-11 07:46:05 UTC) #7
titzer
On 2016/10/11 07:46:05, ahaas wrote: > lgtm with nit > > https://codereview.chromium.org/2405173002/diff/20001/src/runtime/runtime-test.cc > File src/runtime/runtime-test.cc ...
4 years, 2 months ago (2016-10-11 08:09:46 UTC) #10
Clemens Hammacher
https://codereview.chromium.org/2405173002/diff/20001/src/runtime/runtime-test.cc File src/runtime/runtime-test.cc (right): https://codereview.chromium.org/2405173002/diff/20001/src/runtime/runtime-test.cc#newcode766 src/runtime/runtime-test.cc:766: WasmCompiledModuleSerializer::DeserializeWasmModule(isolate, &sc); On 2016/10/11 07:46:05, ahaas wrote: > Couldn't ...
4 years, 2 months ago (2016-10-11 08:19:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405173002/20001
4 years, 2 months ago (2016-10-11 08:25:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 08:28:01 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 08:28:56 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b5861413597a2f9dfec98e9bebc0fad457f726d
Cr-Commit-Position: refs/heads/master@{#40156}

Powered by Google App Engine
This is Rietveld 408576698