Build: Extract debian control files to sysroots

Build: Extract debian control files to sysroots

Adapted from sbc@'s CL https://codereview.chromium.org/2391183002/

R=thestig@chromium.org,sbc@chromium.org

BUG=564904
Committed: https://crrev.com/58974f62d368d3d6dc2f58fe80741804d2147675
Cr-Commit-Position: refs/heads/master@{#424641}

[Tom (Use chromium acct), 2016-10-11 00:06:02]

I finally figured out how to get dpkg-shlibdeps working with the sysroot. 
Basically we just take advantage of the debian/ dir and make sure to use
-l/path/to/sysroot/libs with dpkg-shlibdeps

[Tom (Use chromium acct), 2016-10-11 00:06:07]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 00:06:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 00:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 00:18:23]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2016-10-11 03:06:47]

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
File build/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/sysroot-creator.sh:379: touch
${INSTALL_ROOT}/debian/control
Why make an empty control file here?

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/sysroot-creator.sh:404: mkdir -p
${INSTALL_ROOT}/debian/${base_package}/DEBIAN
How are these "/debian" directories then passed to dpkg-shlibdeps?

It seems a little strange to put all this stuff under /debian in the sysroot.

If it works I don't argue, but hopefully we can switch to more real sysroots
built with debbootstrap soon.

[Tom (Use chromium acct), 2016-10-11 05:33:55]

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
File build/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/sysroot-creator.sh:379: touch
${INSTALL_ROOT}/debian/control
On 2016/10/11 03:06:46, Sam Clegg wrote:
> Why make an empty control file here?

you need it to run dpkg-shlibdeps

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/sysroot-creator.sh:404: mkdir -p
${INSTALL_ROOT}/debian/${base_package}/DEBIAN
On 2016/10/11 03:06:46, Sam Clegg wrote:
> How are these "/debian" directories then passed to dpkg-shlibdeps?
> 

you cd to the dir containing debian/ and then run dpkg-shlibdeps

> It seems a little strange to put all this stuff under /debian in the sysroot.
> 

yeah it's not standard :(  but I needed some place to stuff the control files. 
It doesn't have to be at the root, but the directory needs to be named debian. 
Maybe /impl/debian would be better??

> If it works I don't argue, but hopefully we can switch to more real sysroots
> built with debbootstrap soon.

[Tom (Use chromium acct), 2016-10-12 01:06:29]

pinging Lei

[Lei Zhang, 2016-10-12 01:15:48]

Oh, I figured you two can work this out without me.

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
File build/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/sysroot-creator.sh:379: touch
${INSTALL_ROOT}/debian/control
On 2016/10/11 05:33:55, Tom Anderson wrote:
> On 2016/10/11 03:06:46, Sam Clegg wrote:
> > Why make an empty control file here?
> 
> you need it to run dpkg-shlibdeps

Maybe just add a brief comment to explain why it exists.

[Tom (Use chromium acct), 2016-10-12 01:23:49]

On 2016/10/12 01:15:48, Lei Zhang wrote:
> Oh, I figured you two can work this out without me.

I need you for your OWNERS powers :)

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
File build/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/2405073002/diff/1/build/linux/sysroot_scripts...
build/linux/sysroot_scripts/sysroot-creator.sh:379: touch
${INSTALL_ROOT}/debian/control
On 2016/10/12 01:15:47, Lei Zhang wrote:
> On 2016/10/11 05:33:55, Tom Anderson wrote:
> > On 2016/10/11 03:06:46, Sam Clegg wrote:
> > > Why make an empty control file here?
> > 
> > you need it to run dpkg-shlibdeps
> 
> Maybe just add a brief comment to explain why it exists.

Done.

[Tom (Use chromium acct), 2016-10-12 01:23:57]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 01:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-12 01:30:01]

lgtm

https://codereview.chromium.org/2405073002/diff/20001/build/linux/sysroot_scr...
File build/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/2405073002/diff/20001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/sysroot-creator.sh:378: # The /debian directory is
an implementation detail that's used to cd into
Also, I'm fine with this, but if you think "debian" in the root dir is
confusing, you can do chromium/debian?

[commit-bot: I haz the power, 2016-10-12 01:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:32:56]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-10-12 01:34:39]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-12 01:34:52]

https://codereview.chromium.org/2405073002/diff/20001/build/linux/sysroot_scr...
File build/linux/sysroot_scripts/sysroot-creator.sh (right):

https://codereview.chromium.org/2405073002/diff/20001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/sysroot-creator.sh:378: # The /debian directory is
an implementation detail that's used to cd into
On 2016/10/12 01:30:01, Lei Zhang wrote:
> Also, I'm fine with this, but if you think "debian" in the root dir is
> confusing, you can do chromium/debian?

Acknowledged.

[commit-bot: I haz the power, 2016-10-12 01:35:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:41:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 01:42:54]

Description was changed from

==========
Build: Extract debian control files to sysroots

Adapted from sbc@'s CL https://codereview.chromium.org/2391183002/

R=thestig@chromium.org,sbc@chromium.org

BUG=564904
==========

to

==========
Build: Extract debian control files to sysroots

Adapted from sbc@'s CL https://codereview.chromium.org/2391183002/

R=thestig@chromium.org,sbc@chromium.org

BUG=564904

Committed: https://crrev.com/58974f62d368d3d6dc2f58fe80741804d2147675
Cr-Commit-Position: refs/heads/master@{#424641}
==========

[commit-bot: I haz the power, 2016-10-12 01:42:55]

Patchset 2 (id:??) landed as
https://crrev.com/58974f62d368d3d6dc2f58fe80741804d2147675
Cr-Commit-Position: refs/heads/master@{#424641}