Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2405063002: Tweak --gtest_filter_file switch to support blank lines and comment lines. (Closed)

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
4 years, 2 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak --gtest_filter_file switch to support blank lines and comment lines. BUG=654589 TEST=Manually tried running out/.../bin/run_content_browsertests --gtest-filter-file=$HOME/scratch/file-with-comments-and-blank-lines.txt Committed: https://crrev.com/705aa265b8d39f3b121086030e00986782748e23 Cr-Commit-Position: refs/heads/master@{#424437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Łukasz Anforowicz
klundberg@, could you please take a look? (I would have asked jbudorick@, since he added ...
4 years, 2 months ago (2016-10-10 23:57:48 UTC) #5
mikecase (-- gone --)
I can review CLs while John is out. Don't think klundberg@ has looked at this ...
4 years, 2 months ago (2016-10-11 00:09:18 UTC) #7
mikecase (-- gone --)
lgtm
4 years, 2 months ago (2016-10-11 00:26:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405063002/1
4 years, 2 months ago (2016-10-11 15:38:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 15:44:36 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/705aa265b8d39f3b121086030e00986782748e23 Cr-Commit-Position: refs/heads/master@{#424437}
4 years, 2 months ago (2016-10-11 15:46:01 UTC) #15
jbudorick
4 years, 2 months ago (2016-10-18 16:48:10 UTC) #16
Message was sent while issue was closed.
On 2016/10/11 00:09:18, mikecase wrote:
> I can review CLs while John is out. Don't think klundberg@ has looked at this
> code for a bit.

Thanks for reviewing this :)

Powered by Google App Engine
This is Rietveld 408576698