Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/common/BUILD.gn

Issue 2405013002: Move some global feature defines to buildflags (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/plugins/plugins_handler.cc ('k') | chrome/common/features.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 5a6616d1bc5d0d90dc23786f309b3ca66078b39a..7d12518345ce3ec3bf5dfa9e0a66bee4abb7d64c 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -26,9 +26,12 @@ buildflag_header("features") {
"ANDROID_JAVA_UI=$android_java_ui",
"ENABLE_BACKGROUND=$enable_background",
"ENABLE_BASIC_PRINT_DIALOG=$enable_basic_print_dialog",
+ "ENABLE_CAPTIVE_PORTAL_DETECTION=$enable_captive_portal_detection",
"ENABLE_GOOGLE_NOW=$enable_google_now",
+ "ENABLE_HANGOUT_SERVICES_EXTENSION=$enable_hangout_services_extension",
"ENABLE_ONE_CLICK_SIGNIN=$enable_one_click_signin",
"ENABLE_PACKAGE_MASH_SERVICES=$enable_package_mash_services",
+ "ENABLE_PLUGIN_INSTALLATION=$enable_plugin_installation",
"ENABLE_SERVICE_DISCOVERY=$enable_service_discovery",
"ENABLE_XPC_NOTIFICATIONS=$enable_xpc_notifications",
"PGO_BUILD=$pgo_build",
@@ -568,10 +571,10 @@ static_library("constants") {
]
public_deps = [
+ ":features",
"//content/public/common:result_codes",
]
deps = [
- ":features",
":version_header",
"//base",
"//base/third_party/dynamic_annotations",
« no previous file with comments | « chrome/browser/ui/webui/plugins/plugins_handler.cc ('k') | chrome/common/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698