Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: services/ui/public/cpp/compositor_frame_sink.cc

Issue 2404993002: cc: Stop calling DetachFromClient if bind failed. (Closed)
Patch Set: detachinternal: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/public/cpp/compositor_frame_sink.cc
diff --git a/services/ui/public/cpp/compositor_frame_sink.cc b/services/ui/public/cpp/compositor_frame_sink.cc
index 017f70094e7391d65227549847d6618918789b1d..0f72407095113f6953a8de231effa53fa0c6c01f 100644
--- a/services/ui/public/cpp/compositor_frame_sink.cc
+++ b/services/ui/public/cpp/compositor_frame_sink.cc
@@ -26,6 +26,9 @@ CompositorFrameSink::CompositorFrameSink(
CompositorFrameSink::~CompositorFrameSink() {}
bool CompositorFrameSink::BindToClient(cc::CompositorFrameSinkClient* client) {
+ if (!cc::CompositorFrameSink::BindToClient(client))
+ return false;
+
surface_->BindToThread();
surface_->set_client(this);
@@ -35,7 +38,7 @@ bool CompositorFrameSink::BindToClient(cc::CompositorFrameSinkClient* client) {
base::ThreadTaskRunnerHandle::Get().get())));
client->SetBeginFrameSource(begin_frame_source_.get());
- return cc::CompositorFrameSink::BindToClient(client);
+ return true;
}
void CompositorFrameSink::DetachFromClient() {
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698