Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3480)

Unified Diff: cc/test/fake_compositor_frame_sink.h

Issue 2404993002: cc: Stop calling DetachFromClient if bind failed. (Closed)
Patch Set: detachinternal: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink_unittest.cc ('k') | cc/test/fake_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/fake_compositor_frame_sink.h
diff --git a/cc/test/fake_compositor_frame_sink.h b/cc/test/fake_compositor_frame_sink.h
index fe13f19693985f18bb4d4d165e8bfc827697cc1c..616103e7947e03677b3364d630f99216771da973 100644
--- a/cc/test/fake_compositor_frame_sink.h
+++ b/cc/test/fake_compositor_frame_sink.h
@@ -48,14 +48,14 @@ class FakeCompositorFrameSink : public CompositorFrameSink {
return base::WrapUnique(new FakeCompositorFrameSink(nullptr, nullptr));
}
+ // CompositorFrameSink implementation.
+ void SwapBuffers(CompositorFrame frame) override;
+ void DetachFromClient() override;
+
CompositorFrame* last_sent_frame() { return last_sent_frame_.get(); }
size_t num_sent_frames() { return num_sent_frames_; }
- void SwapBuffers(CompositorFrame frame) override;
-
CompositorFrameSinkClient* client() { return client_; }
- bool BindToClient(CompositorFrameSinkClient* client) override;
- void DetachFromClient() override;
const TransferableResourceArray& resources_held_by_parent() {
return resources_held_by_parent_;
@@ -73,7 +73,6 @@ class FakeCompositorFrameSink : public CompositorFrameSink {
scoped_refptr<ContextProvider> context_provider,
scoped_refptr<ContextProvider> worker_context_provider);
- CompositorFrameSinkClient* client_ = nullptr;
std::unique_ptr<CompositorFrame> last_sent_frame_;
size_t num_sent_frames_ = 0;
TransferableResourceArray resources_held_by_parent_;
« no previous file with comments | « cc/surfaces/direct_compositor_frame_sink_unittest.cc ('k') | cc/test/fake_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698