cc/surfaces/direct_compositor_frame_sink_unittest.cc - Issue 2404993002: cc: Stop calling DetachFromClient if bind failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/direct_compositor_frame_sink_unittest.cc

Issue 2404993002: cc: Stop calling DetachFromClient if bind failed. (Closed)

Patch Set: detachinternal: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/direct_compositor_frame_sink_unittest.cc

diff --git a/cc/surfaces/direct_compositor_frame_sink_unittest.cc b/cc/surfaces/direct_compositor_frame_sink_unittest.cc

index 4291539c1ecafb91c2dca9b9e986b16372196bbf..b15b5212402997b1d51c0e4cb65ebbdde54cd36d 100644

--- a/cc/surfaces/direct_compositor_frame_sink_unittest.cc

+++ b/cc/surfaces/direct_compositor_frame_sink_unittest.cc

@@ -67,7 +67,9 @@ class DirectCompositorFrameSinkTest : public testing::Test {

compositor_frame_sink_client_.did_lose_compositor_frame_sink_called());

}

- ~DirectCompositorFrameSinkTest() override {}

+ ~DirectCompositorFrameSinkTest() override {

+ compositor_frame_sink_->DetachFromClient();

+ }

void SwapBuffersWithDamage(const gfx::Rect& damage_rect) {

std::unique_ptr<RenderPass> render_pass(RenderPass::Create());