Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2404953002: cc/blimp: Set up hooks for scroll/scale sync. (Closed)

Created:
4 years, 2 months ago by Khushal
Modified:
4 years, 2 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc/blimp: Set up hooks for scroll/scale sync. Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale updates from the client and apply to the LayerTreeHostClient. Also sets up proxying of these through the LayerTreeHostRemoteForTesting for LayerTreeTests. BUG=653371, 648442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2 Cr-Commit-Position: refs/heads/master@{#425172}

Patch Set 1 #

Patch Set 2 : missing include #

Total comments: 4

Patch Set 3 : Comments + Rebase #

Total comments: 2

Patch Set 4 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -7 lines) Patch
M cc/blimp/layer_tree_host_remote.h View 2 chunks +9 lines, -0 lines 0 comments Download
M cc/blimp/layer_tree_host_remote.cc View 1 2 3 4 chunks +49 lines, -1 line 0 comments Download
M cc/blimp/layer_tree_host_remote_unittest.cc View 3 chunks +66 lines, -0 lines 0 comments Download
M cc/blimp/remote_compositor_bridge_client.h View 3 chunks +16 lines, -0 lines 0 comments Download
M cc/test/fake_remote_compositor_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_host_remote_for_testing.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M cc/test/layer_tree_host_remote_for_testing.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (16 generated)
Khushal
4 years, 2 months ago (2016-10-10 20:08:06 UTC) #4
Khushal
On 2016/10/10 20:08:06, Khushal wrote: ping. :)
4 years, 2 months ago (2016-10-12 20:09:51 UTC) #12
vmpstr
lgtm https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_host_remote.cc File cc/blimp/layer_tree_host_remote.cc (right): https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_host_remote.cc#newcode168 cc/blimp/layer_tree_host_remote.cc:168: return requested_pipeline_stage_for_next_frame_ == FramePipelineStage::COMMIT; return synchronizing_client_updates_ || requested_pipeline_stage_for_next_frame_ ...
4 years, 2 months ago (2016-10-13 18:32:32 UTC) #13
Khushal
Thanks! https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_host_remote.cc File cc/blimp/layer_tree_host_remote.cc (right): https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_host_remote.cc#newcode168 cc/blimp/layer_tree_host_remote.cc:168: return requested_pipeline_stage_for_next_frame_ == FramePipelineStage::COMMIT; On 2016/10/13 18:32:31, vmpstr ...
4 years, 2 months ago (2016-10-13 18:55:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404953002/40001
4 years, 2 months ago (2016-10-13 18:55:56 UTC) #17
vmpstr
https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_host_remote.cc File cc/blimp/layer_tree_host_remote.cc (right): https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_host_remote.cc#newcode438 cc/blimp/layer_tree_host_remote.cc:438: if (layer == inner_viewport_scroll_layer) It's a two line if ...
4 years, 2 months ago (2016-10-13 19:20:55 UTC) #18
Khushal
https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_host_remote.cc File cc/blimp/layer_tree_host_remote.cc (right): https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_host_remote.cc#newcode438 cc/blimp/layer_tree_host_remote.cc:438: if (layer == inner_viewport_scroll_layer) On 2016/10/13 19:20:55, vmpstr wrote: ...
4 years, 2 months ago (2016-10-13 19:59:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404953002/60001
4 years, 2 months ago (2016-10-13 19:59:41 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-13 21:38:53 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 21:40:57 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2
Cr-Commit-Position: refs/heads/master@{#425172}

Powered by Google App Engine
This is Rietveld 408576698