cc/blimp: Set up hooks for scroll/scale sync.

cc/blimp: Set up hooks for scroll/scale sync.

Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale
updates from the client and apply to the LayerTreeHostClient. Also sets
up proxying of these through the LayerTreeHostRemoteForTesting for
LayerTreeTests.

BUG=653371, 648442
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2
Cr-Commit-Position: refs/heads/master@{#425172}

[Khushal, 2016-10-10 20:07:47]

Description was changed from

==========
cc/blimp: Set up hooks for scroll/scale sync.

Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale
updates from the client and apply to the LayerTreeHostClient. Also sets
up proxying of these through the LayerTreeHostRemoteForTesting for
LayerTreeTests.

BUG=653371,648442
==========

to

==========
cc/blimp: Set up hooks for scroll/scale sync.

Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale
updates from the client and apply to the LayerTreeHostClient. Also sets
up proxying of these through the LayerTreeHostRemoteForTesting for
LayerTreeTests.

BUG=653371,648442
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-10-10 20:07:58]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[Khushal, 2016-10-10 20:08:05]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:08:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 20:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:24:48]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-10-10 21:03:10]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 21:03:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:59:22]

Dry run: This issue passed the CQ dry run.

[Khushal, 2016-10-12 20:09:51]

On 2016/10/10 20:08:06, Khushal wrote:

ping. :)

[vmpstr, 2016-10-13 18:32:32]

lgtm

https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_hos...
File cc/blimp/layer_tree_host_remote.cc (right):

https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_hos...
cc/blimp/layer_tree_host_remote.cc:168: return
requested_pipeline_stage_for_next_frame_ == FramePipelineStage::COMMIT;
return synchronizing_client_updates_ || requested_pipeline_stage_for_next_frame_
== FramePipelineStage::COMMIT;

also please add a comment similar to the one in the header file.

https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_hos...
cc/blimp/layer_tree_host_remote.cc:436: if (layer ==
inner_viewport_scroll_layer)
nit: braces

[Khushal, 2016-10-13 18:55:13]

Thanks!

https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_hos...
File cc/blimp/layer_tree_host_remote.cc (right):

https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_hos...
cc/blimp/layer_tree_host_remote.cc:168: return
requested_pipeline_stage_for_next_frame_ == FramePipelineStage::COMMIT;
On 2016/10/13 18:32:31, vmpstr wrote:
> return synchronizing_client_updates_ ||
requested_pipeline_stage_for_next_frame_
> == FramePipelineStage::COMMIT;
> 
> also please add a comment similar to the one in the header file. 

Done.

https://codereview.chromium.org/2404953002/diff/20001/cc/blimp/layer_tree_hos...
cc/blimp/layer_tree_host_remote.cc:436: if (layer ==
inner_viewport_scroll_layer)
On 2016/10/13 18:32:31, vmpstr wrote:
> nit: braces

I don't have them anywhere in this file, so consistency. :)

[Khushal, 2016-10-13 18:55:22]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-10-13 18:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2404953002/#ps40001
(title: "Comments + Rebase")

[commit-bot: I haz the power, 2016-10-13 18:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-10-13 19:20:55]

https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_hos...
File cc/blimp/layer_tree_host_remote.cc (right):

https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_hos...
cc/blimp/layer_tree_host_remote.cc:438: if (layer ==
inner_viewport_scroll_layer)
It's a two line if statement, so braces aren't optional afaik.

[vmpstr, 2016-10-13 19:21:01]

The CQ bit was unchecked by vmpstr@chromium.org

[Khushal, 2016-10-13 19:59:03]

https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_hos...
File cc/blimp/layer_tree_host_remote.cc (right):

https://codereview.chromium.org/2404953002/diff/40001/cc/blimp/layer_tree_hos...
cc/blimp/layer_tree_host_remote.cc:438: if (layer ==
inner_viewport_scroll_layer)
On 2016/10/13 19:20:55, vmpstr wrote:
> It's a two line if statement, so braces aren't optional afaik.

Oh, so that's the rule. Done.

[Khushal, 2016-10-13 19:59:17]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-10-13 19:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2404953002/#ps60001
(title: "braces")

[commit-bot: I haz the power, 2016-10-13 19:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:38:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-13 21:40:56]

Description was changed from

==========
cc/blimp: Set up hooks for scroll/scale sync.

Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale
updates from the client and apply to the LayerTreeHostClient. Also sets
up proxying of these through the LayerTreeHostRemoteForTesting for
LayerTreeTests.

BUG=653371,648442
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc/blimp: Set up hooks for scroll/scale sync.

Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale
updates from the client and apply to the LayerTreeHostClient. Also sets
up proxying of these through the LayerTreeHostRemoteForTesting for
LayerTreeTests.

BUG=653371,648442
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2
Cr-Commit-Position: refs/heads/master@{#425172}
==========

[commit-bot: I haz the power, 2016-10-13 21:40:57]

Patchset 4 (id:??) landed as
https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2
Cr-Commit-Position: refs/heads/master@{#425172}