Cleanups in runtime.cc

Cleanups in runtime.cc

R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20844

[Jakob Kummerow, 2014-04-17 10:45:50]

LGTM, love it!

https://codereview.chromium.org/240493007/diff/1/src/runtime.cc
File src/runtime.cc (left):

https://codereview.chromium.org/240493007/diff/1/src/runtime.cc#oldcode10933
src/runtime.cc:10933: isolate->heap()->illegal_execution_state_string());
Turning this into a RUNTIME_ASSERT changes the error message being thrown, but
that should never be observable from user code, right?

https://codereview.chromium.org/240493007/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/240493007/diff/1/src/runtime.cc#newcode10915
src/runtime.cc:10915: static bool CheckExecutionState(Isolate* isolate, int
break_id) {
Yes! Enthusiastic +1!

[Yang, 2014-04-17 10:56:42]

https://codereview.chromium.org/240493007/diff/1/src/runtime.cc
File src/runtime.cc (left):

https://codereview.chromium.org/240493007/diff/1/src/runtime.cc#oldcode10933
src/runtime.cc:10933: isolate->heap()->illegal_execution_state_string());
On 2014/04/17 10:45:51, Jakob wrote:
> Turning this into a RUNTIME_ASSERT changes the error message being thrown, but
> that should never be observable from user code, right?

Yes. It should never happen. If it then indeed happens, it really doesn't matter
whether we get an "illegal exception" or "illegal execution state".

[Yang, 2014-04-17 13:05:34]

Committed patchset #3 manually as r20844 (presubmit successful).