native_client_sdk/src/build_tools/build_sdk.py - Issue 240493003: Support static/dynamic for bionic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 240493003: Support static/dynamic for bionic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Enable bionic static/dynamic and nacl_io test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/build_sdk.py

diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py

index e90a142708479621dc24d168617a01cba2eddae6..fdebfed1da8913158d5d783bc0ed2258f9a77dea 100755

--- a/native_client_sdk/src/build_tools/build_sdk.py

+++ b/native_client_sdk/src/build_tools/build_sdk.py

@@ -353,7 +353,6 @@ def MakeNinjaRelPath(path):

TOOLCHAIN_LIBS = {

'bionic' : [

'libminidump_generator.a',

- 'libnacl.a',

binji 2014/04/28 21:01:22 Why? Mention this in the CL description.

noelallen1 2014/04/28 23:00:33 Done.

'libnacl_dyncode.a',

'libnacl_exception.a',

'libnacl_list_mappings.a',