Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 240493003: Support static/dynamic for bionic (Closed)

Created:
6 years, 8 months ago by noelallen1
Modified:
6 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

Unlike the other toolchains, bionic supports both static and dynamic. This CL adds an environment variable which will allow SDK targets to be built with dynamic linking. It also enables additional bionic targets such as nacl_io demo and test. Since the current dynamic loader only supports searching DT_NEEDED namespaces for symbols, bionic forces us to declare dependencies explicitly which causes build order issues. BUG=none R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266900

Patch Set 1 #

Patch Set 2 : Enable bionic static/dynamic and nacl_io test #

Total comments: 10

Patch Set 3 : Fix issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -17 lines) Patch
M native_client_sdk/src/build_tools/build_projects.py View 1 2 3 chunks +23 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/generate_make.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M native_client_sdk/src/examples/api/audio/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/api/graphics_2d/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io/example.dsc View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/gmock/library.dsc View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/resources/Makefile.index.template View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc View 1 1 chunk +9 lines, -8 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
noelallen1
ptal
6 years, 7 months ago (2014-04-28 20:14:21 UTC) #1
binji
lgtm in general, curious about a few things. https://codereview.chromium.org/240493003/diff/20001/native_client_sdk/src/build_tools/build_projects.py File native_client_sdk/src/build_tools/build_projects.py (right): https://codereview.chromium.org/240493003/diff/20001/native_client_sdk/src/build_tools/build_projects.py#newcode107 native_client_sdk/src/build_tools/build_projects.py:107: out.append('%s_DEPS:=%s' ...
6 years, 7 months ago (2014-04-28 21:01:22 UTC) #2
noelallen1
https://codereview.chromium.org/240493003/diff/20001/native_client_sdk/src/build_tools/build_projects.py File native_client_sdk/src/build_tools/build_projects.py (right): https://codereview.chromium.org/240493003/diff/20001/native_client_sdk/src/build_tools/build_projects.py#newcode107 native_client_sdk/src/build_tools/build_projects.py:107: out.append('%s_DEPS:=%s' % (proj['NAME'], ' '.join(localdeps))) On 2014/04/28 21:01:22, binji ...
6 years, 7 months ago (2014-04-28 23:00:32 UTC) #3
noelallen1
6 years, 7 months ago (2014-04-29 16:54:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r266900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698