Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2404913002: Don't lazy-parse arrow functions if we eager compile them (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't lazy-parse arrow functions if we eager compile them R=verwaest@chromium.org BUG= Committed: https://crrev.com/515873cc9b2c8a8c9a6018ebbda7709510a29a98 Cr-Commit-Position: refs/heads/master@{#40152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/parsing/parser-base.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
jochen (gone - plz use gerrit)
4 years, 2 months ago (2016-10-10 16:48:31 UTC) #1
Toon Verwaest
lgtm
4 years, 2 months ago (2016-10-10 17:05:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404913002/1
4 years, 2 months ago (2016-10-10 17:07:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26043)
4 years, 2 months ago (2016-10-10 17:18:40 UTC) #9
jochen (gone - plz use gerrit)
+marja
4 years, 2 months ago (2016-10-11 08:10:32 UTC) #11
marja
lgtm
4 years, 2 months ago (2016-10-11 08:12:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404913002/1
4 years, 2 months ago (2016-10-11 08:13:40 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 08:16:02 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 08:16:21 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/515873cc9b2c8a8c9a6018ebbda7709510a29a98
Cr-Commit-Position: refs/heads/master@{#40152}

Powered by Google App Engine
This is Rietveld 408576698