Chromium Code Reviews| Index: tools/perf/benchmarks/battor.py |
| diff --git a/tools/perf/benchmarks/battor.py b/tools/perf/benchmarks/battor.py |
| index a995dedfe5eaf3e24cda8bbe7d488fca8fd3d671..611ae95ed5d6dc8d7fe0681f72498166051d53c1 100644 |
| --- a/tools/perf/benchmarks/battor.py |
| +++ b/tools/perf/benchmarks/battor.py |
| @@ -2,6 +2,8 @@ |
| # Use of this source code is governed by a BSD-style license that can be |
| # found in the LICENSE file. |
| +import os |
| + |
| from core import perf_benchmark |
| from telemetry.timeline import chrome_trace_category_filter |
| from telemetry.web_perf import timeline_based_measurement |
| @@ -21,7 +23,11 @@ class _BattOrBenchmark(perf_benchmark.PerfBenchmark): |
| # TODO(charliea): Reenable the CPU tracing agent once it no longer causes |
| # indefinite hangs on Windows. |
| # https://crbug.com/647443 |
| - options.config.enable_battor_trace = True |
| + # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once |
| + # the BattOrs stop crashing as their SD cards fill up. |
| + # crbug.com/652384 |
| + options.config.enable_battor_trace = ( |
| + os.environ['BUILDBOT_MASTERNAME'] == 'chromium.perf.fyi') |
|
nednguyen
2016/10/11 14:08:34
you need to use os.environ.get(''BUILDBOT_MASTERNA
|
| options.config.enable_chrome_trace = True |
| options.config.enable_atrace_trace = True |
| options.config.atrace_config.categories = ['sched'] |
| @@ -114,7 +120,11 @@ class BattOrPowerCasesNoChromeTrace(_BattOrBenchmark): |
| def CreateTimelineBasedMeasurementOptions(self): |
| options = timeline_based_measurement.Options() |
| - options.config.enable_battor_trace = True |
| + # TODO(charliea): Reenable BattOr tracing on the main perf waterfall once |
| + # the BattOrs stop crashing as their SD cards fill up. |
| + # crbug.com/652384 |
| + options.config.enable_battor_trace = ( |
| + os.environ['BUILDBOT_MASTERNAME'] == 'chromium.perf.fyi') |
| options.config.enable_chrome_trace = False |
| options.config.chrome_trace_config.SetDefaultOverheadFilter() |
| options.SetTimelineBasedMetrics(['powerMetric', 'clockSyncLatencyMetric']) |