Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-list.html

Issue 2404883002: Add links to MP and resolve minor fixes (Closed)
Patch Set: Make machine provider also be a template Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/tasklist/task-list.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html
index d0be40c41e89ff8ab7f069f5a8c4c6faddfd3aa0..f0d4b185b0a3fd0df554c6b65f249affc307e884 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html
@@ -248,7 +248,7 @@
</template>
<script>
(function(){
- var specialColumns = ["deduped_from", "name", "state", "bot"];
+ var specialColumns = ["deduped_from", "name", "state", "bot", "sk_revision"];
M-A Ruel 2016/10/12 19:35:07 This is still very one off. I would have preferred
kjlubick 2016/10/12 20:02:38 I can take care of it in this CL and update our sw
// Given a time attribute like "abandoned_ts", humanTime returns a function
// that returns the human-friendly version of that attribute. The human
@@ -424,10 +424,11 @@
_skLink: function(task) {
var r = this._attribute(task, "sk_revision")[0];
- if (r === "none") {
+ var repo = this._attribute(task, "sk_repo")[0];
+ if (r === "none" || repo === "none") {
return false;
}
- return "https://skia.googlesource.com/skia/+/" + r;
+ return repo + "/+/"+ r;
M-A Ruel 2016/10/12 19:35:07 This is completely GoB specific. I'd like somethin
kjlubick 2016/10/12 20:02:38 Done. Like the other things, it's a "replace %s w
},
_tag: function(task, col) {

Powered by Google App Engine
This is Rietveld 408576698