Add links to MP and resolve minor fixes

appengine/swarming/elements/res/imp/botpage/bot-page.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <bot-page>
 
@@ skipping 96 matching lines @@
       value="{{_selected}}">
     </url-param>
     <url-param name="show_state"
       value="{{_show_state}}">
     </url-param>
 
     <swarming-app
       client_id="[[client_id]]"
       auth_headers="{{_auth_headers}}"
       permissions="{{_permissions}}"
-      server_version="{{_server_version}}"
+      server_details="{{_server_details}}"
       signed_in="{{_signed_in}}"
 
       busy="[[_or(_busy1,_busy2,_busy3)]]"
       name="Swarming Bot Page">
 
       <h2 hidden$="[[_signed_in]]">You must sign in to see anything useful.</h2>
 
       <div hidden$="[[_not(_signed_in)]]">
 
         <bot-page-data
@@ skipping 74 matching lines @@
                   <td>[[_concat(dim.value)]]</td>
                 </tr>
               </template>
 
               <tr title="IP address that the server saw the connection from.">
                 <td>External IP</td>
                 <td><a href$="[[_bot.external_ip]]">[[_bot.external_ip]]</a></td>
                 <td></td>
               </tr>
               <tr
-                  class$="[[_classVersion(_server_version.bot_version,_bot.version)]]"
+                  class$="[[_classVersion(_server_details.bot_version,_bot.version)]]"
                   title="Version is based on the content of swarming_bot.zip which is the swarming bot code. The bot won't update if quarantined, dead, or busy.">
                 <td>Bot Version</td>
                 <td>[[_shorten(_bot.version,'8')]]</td>
                 <td></td>
               </tr>
               <tr title="The version the server expects the bot to be using.">
                 <td>Expected Bot Version</td>
-                <td>[[_shorten(_server_version.bot_version,'8')]]</td>
+                <td>[[_shorten(_server_details.bot_version,'8')]]</td>
                 <td></td>
               </tr>
               <tr title="First time ever a bot with this id contacted the server.">
                 <td>First seen</td>
                 <td title="[[_bot.human_first_seen_ts]]">
                   [[_timeDiffApprox(_bot.first_seen_ts)]] ago
                 </td>
                 <td></td>
               </tr>
               <tr title="How the bot is authenticated by the server.">
                 <td>Authenticated as</td>
                 <td colspan=2>[[_bot.authenticated_as]]</td>
               </tr>
               <template is="dom-if" if="[[_bot.lease_id]]">
                 <tr>
                   <td>Machine Provider Lease ID</td>
-                  <td colspan=2>[[_bot.lease_id]]</td>
+                  <td colspan=2>
+                    <a href$="[[_mpLink(_bot,_server_details.machine_provider_template)]]">
+                      [[_bot.lease_id]]
+                    </a>
+                  </td>
                 </tr>
                 <tr>
                   <td>Machine Provider Lease Expires</td>
                   <td colspan=2>[[_bot.human_lease_expiration_ts]]</td>
                 </tr>
               </template>
             </table>
 
             <span class="title">State</span>
 
@@ skipping 78 matching lines @@
                 <tr>
                   <td class="message">[[event.message]]</td>
                   <td>[[event.event_type]]</td>
                   <td>[[event.human_ts]]</td>
                   <td>
                     <a target="_blank" rel="noopener"
                         href$="[[_taskLink(event.task_id)]]">
                       [[event.task_id]]
                     </a>
                   </td>
-                  <td class$="[[_classVersion(_server_version.bot_version,event.version)]]">
-                    <a target="_blank" rel="noopener"
-                        href$="[[_luciLink(event.version)]]">
+                  <td class$="[[_classVersion(_server_details.bot_version,event.version)]]">
                       [[_shorten(event.version,'8')]]
-                    </a>
                   </td>
                 </tr>
               </template>
             </tbody>
           </table>
         </template>
         <!-- https://github.com/Polymer/polymer/issues/3669 hidden$ doesn't
             respect truthiness, only booleanness, so we have _showEvents
             instead of using _selected directly.-->
         <pageable-data
@@ skipping 151 matching lines @@
           return "dead";
         }
         return "";
       },
 
       _luciLink: function(revision) {
         if (!revision) {
           return undefined;
         }
         return "https://github.com/luci/luci-py/commit/" + revision;
+      },
 
+      _mpLink: function(bot, template) {
+        if (!bot || !bot.lease_id || !template) {
+          return false;
+        }
+        return template.replace("%s", bot.lease_id);
       },
 
       _numRows: function(arr) {
         if (!arr || !arr.length) {
           return 1;
         }
         return 1 + arr.length;
       },
 
       _prettyPrint: function(obj) {
@@ skipping 77 matching lines @@
       },
 
       _toggleState: function() {
         this.set("_show_state", !this._show_state);
       }
 
     });
   })();
   </script>
 </dom-module>