Add links to MP and resolve minor fixes

appengine/swarming/elements/res/imp/taskpage/task-page.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <task-page>
 
@@ skipping 88 matching lines @@
     <url-param name="refresh"
       value="{{_refresh_interval}}"
       default_value="10">
     </url-param>
 
     <swarming-app
       client_id="[[client_id]]"
       auth_headers="{{_auth_headers}}"
       permissions="{{_permissions}}"
       profile="{{_profile}}"
+      server_details="{{_server_details}}"
       signed_in="{{_signed_in}}"
 
       busy="[[_busy]]"
       name="Swarming Task Page">
 
       <h2 hidden$="[[_signed_in]]">You must sign in to see anything useful.</h2>
 
       <div hidden$="[[_not(_signed_in)]]">
 
         <task-page-data
@@ skipping 310 matching lines @@
                 value="{{_refresh_interval}}"
                 title="How often to refresh all information about the task"
                 auto-validate
                 min="1"
                 max="1000"
                 pattern="[0-9]+">
               </paper-input>
             </div>
 
             <template is="dom-if" if="[[_supportsMilo(_request,_show_raw)]]">
-              <iframe id="miloFrame" class="milo tabbed" src$="[[_getMiloLink(milo_prefix,task_id)]]"></iframe>
+              <iframe id="miloFrame" class="milo tabbed" src$="[[_getDisplayServerLink(_server_details.display_server_url_template,task_id)]]"></iframe>
             </template>
             <template is="dom-if" if="[[_show_raw]]">
               <div class="code stdout tabbed">[[_stdout]]</div>
             </template>
           </div>
         </div>
       </div>
     </swarming-app>
 
     <paper-dialog id="prompt" modal on-iron-overlay-closed="_promptClosed">
@@ skipping 21 matching lines @@
           SwarmingBehaviors.TaskBehavior,
       ],
 
       properties: {
         task_id: {
           type: String,
         },
         client_id: {
           type: String,
         },
-        milo_prefix: {
-          type: String,
-        },
-
 
         _dialogPrompt: {
           type: String,
           value: "",
         },
         _refresh_interval: {
           type: Number,
         },
         _request: {
           type: Object,
           observer: "_requestUpdated"
         },
         _request_detail: {
           type: Boolean,
         },
         _result: {
           type: Object,
         },
+        _server_details: {
+          type: Object,
+        },
         _stdout: {
           type: String,
         }
       },
 
       _alias: function(dim) {
         var values = dim.value;
         if (!Array.isArray(values)) {
           values = [values];
         }
@@ skipping 69 matching lines @@
         return args.join(" ");
       },
 
       _failureClass: function(failure) {
         if (failure) {
           return "failed_task";
         }
         return "";
       },
 
-      _getMiloLink: function(prefix,id) {
-        if (!prefix) {
+      _getDisplayServerLink: function(template,id) {
+        if (!template) {
           return undefined;
         }
-        return prefix + id;
+        return template.replace("%s", id);
       },
 
       _internalClass: function(failure) {
         if (failure) {
           return "exception";
         }
         return "";
       },
 
       _isolateLink: function(ref) {
@@ skipping 51 matching lines @@
       },
 
       _softRefresh: function() {
         if (this._result && this._result.state !== "RUNNING" &&
             this._result.state !==  "PENDING") {
           return;
         }
         this.$.data.reload();
         var miloFrame = this.$$("iframe")
         if (miloFrame) {
-          miloFrame.src = this._getMiloLink(this.milo_prefix,this.task_id);
+          miloFrame.src = this._getDisplayServerLink(this._server_details.display_server_url_template,this.task_id);
         }
       },
 
       _retryTask: function() {
         if (!this._request) {
           sk.errorMessage("Task not yet loaded", 3000);
           return;
         }
         var newTask = {
           expiration_secs: this._request.expiration_secs,
@@ skipping 62 matching lines @@
         return result && result.state !== this.PENDING && result.state !== this.CANCELED && result.state != this.EXPIRED;
       },
 
       _wasNotPickedUp: function(result) {
         return result && !this._wasPickedUp(result);
       },
     });
   })();
   </script>
 </dom-module>